Changeset 062583 in git for factory/facAlgExt.cc

Timestamp:

Mar 9, 2012, 12:09:29 PM (11 years ago)

Author:

Martin Lee <martinlee84@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'f875bbaccd0831e36aaed09ff6adeb3eb45aeb94')

Children:

1ddcde904c894e6fac1afc8cced863fa937c072d

Parents:

24c6177e872b135f0188fea998eb45a75e3fde6e

git-author:

Martin Lee <martinlee84@web.de>2012-03-09 12:09:29+01:00

git-committer:

Martin Lee <martinlee84@web.de>2012-04-04 14:42:27+02:00

Message:

chg: shift factors of the norm instead of factors over Q(a)

File:

• factory/facAlgExt.cc (modified) (1 diff)

factory/facAlgExt.cc

@@ -123 +123 @@
   normFactors.removeFirst();
   CanonicalForm buf;
-  if (shift != 0)
-    buf= f (f.mvar() - shift*alpha, f.mvar());
-  else
-    buf= f;
+  buf= f;
   CanonicalForm factor;
   for (CFFListIterator i= normFactors; i.hasItem(); i++)
   {
     ASSERT (i.getItem().exp() == 1, "norm not squarefree");
-    factor= gcd (buf, i.getItem().factor());
+    if (shift == 0)
+      factor= gcd (buf, i.getItem().factor());
+    else
+      factor= gcd (buf, i.getItem().factor() (f.mvar() + shift*alpha, f.mvar()));
     buf /= factor;
-    if (shift != 0)
-      factor= factor (f.mvar() + shift*alpha, f.mvar());
     factors.append (factor);
   }