Changeset 06b3e8 in git

Timestamp:

Dec 7, 2017, 11:10:06 AM (6 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

a1d4a2fe2dac9eb7b440649aca38054530ce8ea0

Parents:

aad4ca42fd2df029c3026bf93dfc208d7275cbdb

Message:

fix: (temp.) bug fix by Albert Heinle

File:

• Singular/LIB/ncfactor.lib (modified) (9 diffs)

Singular/LIB/ncfactor.lib

@@ -1 +1 @@
 ///////////////////////////////////////////////////////////
-version="version ncfactor.lib 4.0.3.2 Jul_2016 "; // $Id$
+version="version ncfactor.lib 4.1.1.0 Dec_2017 "; // $Id$
 category="Noncommutative";
 info="
@@ -8 +8 @@
 
 OVERVIEW:
-@texinfo
-  In this library, new methods for factorization on polynomials
+  New methods for factorization on polynomials
   are implemented for three types of algebras, all generated by
-  2*n, n in NN, generators (n'th Weyl, n'th shift and graded polynomials in n'th q-Weyl algebras)
-  over a field K.
+   2*n, n in NN, generators (n'th Weyl, n'th shift and graded polynomials in n'th q-Weyl algebras)
+   over a field K.
 @* More detailled description of the algorithms and related publications can be found at
   @uref{https://cs.uwaterloo.ca/\~aheinle/}.
-@end texinfo
 
 PROCEDURES:
@@ -6737 +6735 @@
     result = 0;
   }
+  input = (x(1)^2 +x(1)*d(1)+2)*(x(1)+d(1));
+  expected = list(list(number(1), x(1)+d(1), x(1)+d(1), x(1)),
+                  list(number(1), x(1)^2+x(1)*d(1)+2, x(1)+d(1)));
+  obtained = facWeyl(input);
+  if ((!isListEqual(expected,obtained)))
+  {
+    print("Test 5 for facWeyl failed.");
+    print("Expected:\n");
+    print(expected);
+    print("obtained:\n");
+    print(obtained);
+    result = 0;
+  }
   return(result);
 }//testing facWeyl
@@ -6815 +6826 @@
       for (j=i+1; j<=posRight; j++)
       {//multiplying homogeneous elements from the right
-    if(!homogwithorderNthWeyl(factors[j]))
-    {break;}
-    tempElem = tempElem*factors[j];
-    tempRightBorder = j;
+        if(!homogwithorderNthWeyl(factors[j]))
+        {break;}
+        tempElem = tempElem*factors[j];
+        tempRightBorder = j;
       }//multiplying homogeneous elements from the right
       for (j=i-1; j>=posLeft; j--)
@@ -7038 +7049 @@
     return(homogfacNthWeyl_all(h));
   }//we are already dealing with a -1,1 homogeneous poly
+  return(ncfactor_without_opt(h)); //temp fix for now; soon, a more
+                                   //major refactor follows
   list resulttemp =
     extractHomogeneousDivisorsNthWeyl(h/commonCoefficient);
@@ -10796 +10809 @@
   for (i = 1; i<=voice;i++)
   {dbprintWhitespace = dbprintWhitespace + " ";}
-
+  return(ncfactor_without_opt(h));//temporary thing until bugfix.
   //---------- Start of interesting part ----------
 
@@ -11466 +11479 @@
 
 proc homogfacNthQWeyl(poly h)
-"USAGE:
-@format
-homogfacNthQWeyl(h); h is a homogeneous polynomial in the
+"USAGE: homogfacNthQWeyl(h); h is a homogeneous polynomial in the
  n'th q-Weyl algebra with respect to the weight vector
- [-1,...,-1,1,...,1].
-  \__  __/  \__  __/
-     \/        \/
-     n/2       n/2
-@end format
+@ [-1,...,-1,1,...,1].
+@  \__  __/  \__  __/
+@     \/        \/
+@     n/2       n/2
 RETURN: list
 PURPOSE: Computes a factorization of a homogeneous polynomial h
@@ -11769 +11779 @@
 @format
 homogfacNthQWeyl_all(h); h is a homogeneous polynomial in the
-  n'th q-Weyl algebra with respect to the weight vector
-
-  [-1,...,-1,1,...,1].
-   \__  __/  \__  __/
-      \/        \/
-      n/2       n/2
+ n'th q-Weyl algebra with respect to the weight vector
+ [-1,...,-1,1,...,1].
+  \__  __/  \__  __/
+     \/        \/
+     n/2       n/2
 @end format
 RETURN: list
@@ -11788 +11797 @@
  - We have n parameters q_1,..., q_n given.
 
-SEE ALSO: homogfacFirstQWeyl, homogfacFirstQWeyl_all
+SEE ALSO: homogfacNthWeyl, homogfacFirstQWeyl, homogfacFirstQWeyl_all
 "
 {//proc homogfacNthQWeyl_all