Changeset 07fefd in git

Timestamp:

Nov 29, 2022, 11:58:20 AM (2 months ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'ad2543eab51733612ba7d118afc77edca719600e')

Children:

82410da1bb6e5c5036500137a8c9494ad341946c

Parents:

a1848a8b477dcf2db252b506e9fd7ceba77fd0548b6880871eb7f0dea5b3bbc2efc8c11035bf5d3b

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2022-11-29 11:58:20+01:00

git-committer:

GitHub <noreply@github.com>2022-11-29 11:58:20+01:00

Message:

Merge pull request #1164 from ssalone/BugFix_symNsym

Bug fix symNsym: fix and some comments corrected

File:

• Singular/LIB/chern.lib (modified) (4 diffs)

Singular/LIB/chern.lib

@@ -177 +177 @@
           as well a non-symmetric remainder
 EXAMPLE:  example symNsym; shows an example
-NOTE:     constants are not considered symmetric
+NOTE:     constants are considered symmetric
 "
 {
@@ -215 +215 @@
   list l=symm(list(A@(1..nV) )); // symmetric functions in A@(i)
   intvec v=leadexp(f), 0; // the exponent of the leading monomial
+  int exponent;
+  // We proceed as if the initial polynomial were symmetric.
+  // Under this assumption the leading monomial will always be of the form
+  // A@(1)^n1 * A@(2)^n2 * ... * A@(nV)^nnV, n1 >= n2 >= ... >= nnV.
+  // Everything which contradicts this assumption is considered as a part of the remainder.
   while(v[N1]!=0)
   {
     mon=leadcoef(f); // leading coefficient of f
     monc=mon;
-    for(i=1; v[N1+i-1]!=0 ;i++ )
-    {
-      mon = mon*c@(i)^( v[N1+i-1]-v[N1+i] );
-      monc = monc*l[i]^( v[N1+i-1]-v[N1+i] ); // has the same leading coefficient as f
-    }
-    rez1=rez1+mon; // add a monomial
-    f=f-monc; // subtract the monomial
+    for(i=1; i<=nV && mon !=0 ;i++ )
+    {
+      exponent = v[N1+i-1]-v[N1+i];
+      if( exponent >=0 ) // symmetric case
+      {
+        mon = mon*c@(i)^exponent;
+        monc = monc*l[i]^exponent; // has the same leading coefficient as f
+      }
+      else // not the symmetric case
+      {
+        mon=0;
+        monc=0;
+      }
+    }
+    if(mon==0) // not the symmetric case
+    {
+      rez2=rez2+lead(f);
+      f=f-lead(f);
+    }
+    else // symmetric case
+    {
+      rez1=rez1+mon; // add a monomial
+      f=f-monc; // subtract the monomial
+    }
     v=leadexp(f), 0;
   }
@@ -245 +267 @@
   list l=c(1..3);
   // The symmetric part of f = 3x2 + 3y2 + 3z2 + 7xyz + y
-  // in terms of the elemenatary symmetric functions c(1), c(2), c(3)
+  // in terms of the elementary symmetric functions c(1), c(2), c(3)
   // and the remainder
   poly f = 3x2 + 3y2 + 3z2 + 7xyz + y;
   print( symNsym(f, l) );
-  // Take a symmetrix polynomial in variables x and z
+  // Take a symmetric polynomial in variables x and z
   f=x2+xz+z2;
   // Express it in terms of the elementary the symmetric functions
@@ -2479 +2501 @@
   print( cProj(1) );
 
-  // the coefficients of the total Chern class of the complex projective line
+  // the coefficients of the total Chern class of the complex projective plane
   print( cProj(2) );
 
-  // the coefficients of the total Chern class of the complex projective line
+  // the coefficients of the total Chern class of the complex projective space
+  // of dimension three
   print( cProj(3) );
 }