Changeset 0be039 in git for Singular/LIB/fpaprops.lib

Timestamp:

Mar 16, 2018, 6:27:45 PM (6 years ago)

Author:

Karim Abou Zeid <karim23697@…>

Branches:

(u'spielwiese', '8e0ad00ce244dfd0756200662572aef8402f13d5')

Children:

52ac0882b123798821765bb16d5ba4b371ced4cd

Parents:

95a42a2dacdcadb5c004cb3520b5c252dfe8e784df09c0184ffc4aaf31c02b8691e68734f25fc3b3

Message:

Merge branch 'lpDivision' into stable

File:

• Singular/LIB/fpaprops.lib (modified) (13 diffs)

Singular/LIB/fpaprops.lib

@@ -19 +19 @@
 PROCEDURES:
   lpNoetherian(<GB>);     check whether A/<GB> is (left/right) noetherian
-  lpIsSemiPrime(<GB>);    check whether A/<GB> is semi prime
-  lpIsPrime(<GB>);        check whether A/<GB> is prime
+  lpIsSemiPrime(<GB>);    check whether A/<LM(GB)> is semi prime
+  lpIsPrime(<GB>);        check whether A/<LM(GB)> is prime
   lpGkDim(<GB>);          compute the Gelfand Kirillov dimension of A/<GB>
   lpGlDimBound(<GB>);     compute an upper bound for the global dimension of A/<GB>
@@ -37 +37 @@
 @*      2 right noetherian
 @*      3 noetherian
-PURPOSE: Check whether R/<G> is (left/right) noetherian, where R is the basering
+PURPOSE: Check whether A/<G> is (left/right) noetherian
 ASSUME: - basering is a Letterplace ring
 @*      - G is a Groebner basis
@@ -108 +108 @@
   return (3 - inFlag - outFlag);
 }
-example {
+example
+{
   "EXAMPLE:"; echo = 2;
   ring r = 0,(x,y),dp;
@@ -198 +199 @@
 "USAGE: lpIsSemiPrime(G); G an ideal in a Letterplace ring
 RETURN: boolean
-PURPOSE: Check whether R/<G> is semi prime, where R is the basering
+PURPOSE: Check whether A/<LM(G)> is semi prime, that is when p * (A/<LM(G)>) * p != 0 for all p in (A/<LM(G)> - {0}).
 ASSUME: - basering is a Letterplace ring
       - G is a Groebner basis
@@ -249 +250 @@
   return (1);
 }
-example {
+example
+{
   "EXAMPLE:"; echo = 2;
   ring r = 0,(x1,x2),dp;
@@ -298 +300 @@
 "USAGE: lpIsPrime(G); G an ideal in a Letterplace ring
 RETURN: boolean
-PURPOSE: Check whether R/<G> is prime, where R is the basering
+PURPOSE: Check whether A/<LM(G)> is prime, that is when p1 * (A/<LM(G)>) * p2 != 0 for all p1, p2 in (A/<LM(G)> - {0}).
 ASSUME: - basering is a Letterplace ring
       - G is a Groebner basis
@@ -362 +364 @@
   return (1);
 }
-example {
+example
+{
   "EXAMPLE:"; echo = 2;
   ring r = 0,(x,y),dp;
@@ -681 +684 @@
   return (UG);
 }
-example {
+example
+{
   "EXAMPLE:"; echo = 2;
   ring r = 0,(x,y,z),dp;
@@ -1047 +1051 @@
     for (int j = 1; j <= size(ivfi); j++) {
       int varindex = ivfi[j];
-      int subindex = lpIndexOf(s1, var(varindex));
-      if (subindex > 0) {
-        s2[subindex] = lpNF(s2[subindex],G);
-        fis = lpMult(fis, s2[subindex]);
-      } else {
-        fis = lpMult(fis, lpNF(iv2lp(varindex),G));
-      }
-      /*fis = lpNF(fis,G);*/
-      kill varindex; kill subindex;
+      if (varindex > 0) {
+        int subindex = lpIndexOf(s1, var(varindex));
+        if (subindex > 0) {
+          s2[subindex] = lpNF(s2[subindex],G);
+          fis = lpMult(fis, s2[subindex]);
+        } else {
+          fis = lpMult(fis, lpNF(iv2lp(varindex),G));
+        }
+        /*fis = lpNF(fis,G);*/
+        kill subindex;
+      }
+      kill varindex;
     } kill j;
     kill ivfi;
@@ -1065 +1072 @@
   return (fs);
 }
-example {
+example
+{
+  "EXAMPLE:"; echo = 2;
   //////// EXAMPLE A ////////
   ring r = 0,(x,y,z),dp;
@@ -1144 +1153 @@
     for (int j = 1; j <= size(ivfi); j++) {
       int varindex = ivfi[j];
-      int subindex = lpIndexOf(s1, var(varindex));
-      if (subindex > 0) {
-        tmpDegBound = tmpDegBound + deg(s2[subindex]);
-      } else {
-        tmpDegBound = tmpDegBound + 1;
-      }
-      kill varindex; kill subindex;
+      if (varindex > 0) {
+        int subindex = lpIndexOf(s1, var(varindex));
+        if (subindex > 0) {
+          tmpDegBound = tmpDegBound + deg(s2[subindex]);
+        } else {
+          tmpDegBound = tmpDegBound + 1;
+        }
+        kill subindex;
+      }
+      kill varindex;
     } kill j;
     if (tmpDegBound > maxDegBound) {
@@ -1160 +1172 @@
   // increase degbound by 50% when ideal is provided
   // needed for lpNF
-  maxDegBound = maxDegBound + maxDegBound/2;
+  maxDegBound = maxDegBound + (maxDegBound div 2);
 
   return (maxDegBound);
 }
-example {
+example
+{
   // see lpSubstitute()
 }
@@ -1187 +1200 @@
   return (maxDegBound);
 }
-example {
+example
+{
   // see lpSubstitute()
 }