Changeset 118753 in git

Timestamp:

Aug 3, 2011, 7:59:35 PM (13 years ago)

Author:

Burcin Erocal <burcin@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

d16ea9b1d0fce4837d7154d0bdcaa13889e507bc

Parents:

711e26e8e44ee1e7919f92468e0e401554543926

git-author:

Burcin Erocal <burcin@erocal.org>2011-08-03 19:59:35+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 13:14:23+01:00

Message:

A few fixes for Singular/iparith.cc.

File:

• Singular/iparith.cc (modified) (23 diffs)

Singular/iparith.cc

@@ -80 +80 @@
 #ifdef HAVE_PLURAL
   #include <kernel/ratgring.h>
-  #include <kernel/sca.h>
+  #include <polys/nc/sca.h>
   #define ALLOW_PLURAL     1
   #define NO_PLURAL        0
@@ -1698 +1698 @@
   poly p = pInit();
   int i;
-  for (i=1; i<=pVariables; i++)
+  for (i=1; i<=currRing->N; i++)
   {
     pSetExp(p, i, 1);
@@ -1720 +1720 @@
   int i;
   for(i=IDELEMS(I);i>=0;i--) d=si_max(d,(int)pDegW(I->m[i],iv));
-  omFreeSize((ADDRESS)iv,(pVariables+1)*sizeof(short));
+  omFreeSize((ADDRESS)iv,(currRing->N+1)*sizeof(short));
   res->data = (char *)((long)d);
   return FALSE;
@@ -1731 +1731 @@
     short *iv=iv2array((intvec *)v->Data());
     int d=(int)pDegW(p,iv);
-    omFreeSize((ADDRESS)iv,(pVariables+1)*sizeof(short));
+    omFreeSize((ADDRESS)iv,(currRing->N+1)*sizeof(short));
     res->data = (char *)(long(d));
   }
@@ -2062 +2062 @@
       }
     }
-    if ((iiOp!=FETCH_CMD) || (r->N!=pVariables) || (rPar(r)!=rPar(currRing)))
+    if ((iiOp!=FETCH_CMD) || (r->N!=currRing->N) || (rPar(r)!=rPar(currRing)))
     {
       perm=(int *)omAlloc0((r->N+1)*sizeof(int));
@@ -2070 +2070 @@
       if (iiOp==IMAP_CMD)
       {
-        maFindPerm(r->names,       r->N,       r->parameter,        r->P,
-                   currRing->names,currRing->N,currRing->parameter, currRing->P,
+        maFindPerm(r->names,       r->N,       rParameter(r),        r->P,
+                   currRing->names,currRing->N,rParameter(currRing), currRing->P,
                    perm,par_perm, currRing->ch);
       }
@@ -2079 +2079 @@
         if (par_perm_size!=0)
           for(i=si_min(rPar(r),rPar(currRing))-1;i>=0;i--) par_perm[i]=-(i+1);
-        for(i=si_min(r->N,pVariables);i>0;i--) perm[i]=i;
+        for(i=si_min(r->N,currRing->N);i>0;i--) perm[i]=i;
       }
     }
@@ -2085 +2085 @@
     {
       int i;
-      for(i=0;i<si_min(r->N,pVariables);i++)
+      for(i=0;i<si_min(r->N,currRing->N);i++)
       {
         Print("// var nr %d: %s -> %s\n",i,r->names[i],currRing->names[i]);
@@ -2092 +2092 @@
       {
         Print("// par nr %d: %s -> %s\n",
-              i,r->parameter[i],currRing->parameter[i]);
+              i,rParameter(r)[i],rParameter(currRing)[i]);
       }
     }
@@ -2528 +2528 @@
   int i,e;
   BOOLEAN err=FALSE;
-  for(i=si_min(pVariables,iv->length()); i>0; i--)
+  for(i=si_min(currRing->N,iv->length()); i>0; i--)
   {
     e=(*iv)[i-1];
@@ -2534 +2534 @@
     else err=TRUE;
   }
-  if (iv->length()==(pVariables+1))
+  if (iv->length()==(currRing->N+1))
   {
     res->rtyp=VECTOR_CMD;
-    e=(*iv)[pVariables];
+    e=(*iv)[currRing->N];
     if (e>=0) pSetComp(p,e);
     else err=TRUE;
@@ -2560 +2560 @@
   int p=0;
   if ((0<i)
-  && (IDRING(h)->parameter!=NULL)
+  && (rParameter(IDRING(h))!=NULL)
   && (i<=(p=rPar(IDRING(h)))))
-    res->data=omStrDup(IDRING(h)->parameter[i-1]);
+    res->data=omStrDup(rParameter(IDRING(h))[i-1]);
   else
   {
@@ -2821 +2821 @@
   if ((maxl==-1) /*&& (iiOp!=MRES_CMD)*/)
   {
-    maxl = pVariables-1+2*(iiOp==MRES_CMD);
+    maxl = currRing->N-1+2*(iiOp==MRES_CMD);
     if (currQuotient!=NULL)
     {
@@ -2938 +2938 @@
   if ((maxl==-1) /*&& (iiOp!=MRES_CMD)*/)
   {
-    maxl = pVariables-1+2*(iiOp==MRES_CMD);
+    maxl = currRing->N-1+2*(iiOp==MRES_CMD);
     if (currQuotient!=NULL)
     {
@@ -4087 +4087 @@
 static BOOLEAN jjJACOB_P(leftv res, leftv v)
 {
-  ideal i=idInit(pVariables,1);
+  ideal i=idInit(currRing->N,1);
   int k;
   poly p=(poly)(v->Data());
-  for (k=pVariables;k>0;k--)
+  for (k=currRing->N;k>0;k--)
   {
     i->m[k-1]=pDiff(p,k);
@@ -4099 +4099 @@
 /*2
  * compute Jacobi matrix of a module/matrix
- * Jacobi(M) := ( diff(Mt,var(1))|, ... ,| diff(Mt,var(pVariables))  ),
+ * Jacobi(M) := ( diff(Mt,var(1))|, ... ,| diff(Mt,var(currRing->N))  ),
  * where Mt := transpose(M)
  * Note that this is consistent with the current conventions for jacob in Singular,
@@ -4110 +4110 @@
   int W = IDELEMS(id);
 
-  ideal result = idInit(W * pVariables, id->rank);
+  ideal result = idInit(W * currRing->N, id->rank);
   poly *p = result->m;
 
-  for( int v = 1; v <= pVariables; v++ )
+  for( int v = 1; v <= currRing->N; v++ )
   {
     poly* q = id->m;
@@ -4163 +4163 @@
 {
   poly p=(poly)v->Data();
-  int s=pVariables;
+  int s=currRing->N;
   if (v->Typ()==VECTOR_CMD) s++;
   intvec *iv=new intvec(s);
   if (p!=NULL)
   {
-    for(int i = pVariables;i;i--)
+    for(int i = currRing->N;i;i--)
     {
       (*iv)[i-1]=pGetExp(p,i);
     }
-    if (s!=pVariables)
-      (*iv)[pVariables]=pGetComp(p);
+    if (s!=currRing->N)
+      (*iv)[currRing->N]=pGetComp(p);
   }
   res->data=(char *)iv;
@@ -4408 +4408 @@
   int i=(int)(long)v->Data();
   int p=0;
-  if ((0<i) && (currRing->parameter!=NULL) && (i<=(p=rPar(currRing))))
-    res->data=omStrDup(currRing->parameter[i-1]);
+  if ((0<i) && (rParameter(currRing)!=NULL) && (i<=(p=rPar(currRing))))
+    res->data=omStrDup(rParameter(currRing)[i-1]);
   else
   {
@@ -5508 +5508 @@
 {
   intvec *wdegree=(intvec*)w->Data();
-  if (wdegree->length()!=pVariables)
+  if (wdegree->length()!=currRing->N)
   {
     Werror("weight vector must have size %d, not %d",
-           pVariables,wdegree->length());
+           currRing->N,wdegree->length());
     return TRUE;
   }
@@ -5626 +5626 @@
   short *iw=iv2array((intvec *)w->Data());
   res->data = (char *)ppJetW((poly)u->Data(),(int)(long)v->Data(),iw);
-  omFreeSize((ADDRESS)iw,(pVariables+1)*sizeof(short));
+  omFreeSize((ADDRESS)iw,(currRing->N+1)*sizeof(short));
   return FALSE;
 }
@@ -6202 +6202 @@
   maxl--;
   if ((maxl==-1) && (iiOp!=MRES_CMD))
-    maxl = pVariables-1;
+    maxl = currRing->N-1;
   if ((iiOp == RES_CMD) || (iiOp == MRES_CMD))
   {
@@ -6382 +6382 @@
     w=iv2array((intvec *)v4->Data());
     short *w0=w+1;
-    int i=pVariables;
+    int i=currRing->N;
     while(i>0&&*w0>0)
     {