Changeset 12e275 in git for libpolys/coeffs/rmodulon.cc

Timestamp:

Dec 4, 2014, 5:51:33 PM (9 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', '2fa36c576e6a4ddbb1093b43c7f8e9835e17e52a')

Children:

f19aa6812e6421a0bbd161f43b974557d7f6b874

Parents:

fe6b623ec279088e48111ca37e0592c7d7a54822

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2014-12-04 17:51:33+01:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2014-12-15 18:49:40+01:00

Message:

Mark deprecated BIGINT handling + related bugs / side effects

FIXMEs: nlGMP -> n_MPZ. Check for side effects and nlMapGMP
Fix: bug in BIGINT deletion
Fix: a possible bug due to sideeffect!?

File:

• libpolys/coeffs/rmodulon.cc (modified) (2 diffs)

libpolys/coeffs/rmodulon.cc

@@ -60 +60 @@
 nMapFunc nrnSetMap     (const coeffs src, const coeffs dst);
 #if SI_INTEGER_VARIANT==2
-extern void    nrzWrite       (number &a, const coeffs r); // FIXME
+// FIXME? TODO? // extern void    nrzWrite       (number &a, const coeffs r); // FIXME
 # define  nrnWrite      nrzWrite
 #else
@@ -818 +818 @@
 {
   mpz_ptr erg = (mpz_ptr)omAllocBin(gmp_nrz_bin);
-  mpz_init(erg);
-  nlGMP(from, (number)erg, src);
+  mpz_init(erg);  
+  nlGMP(from, (number)erg, src); // FIXME? TODO? // extern void   nlGMP(number &i, number n, const coeffs r); // to be replaced with n_MPZ(erg, from, src); // ?
   mpz_mod(erg, erg, dst->modNumber);
   return (number)erg;