Changeset 1374bc in git for libpolys/polys/ext_fields/transext.cc

Timestamp:

Nov 23, 2011, 3:29:54 PM (12 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'd0474371d8c5d8068ab70bfb42719c97936b18a6')

Children:

da6ad4f6a78a843c8fb63f7d9e3cfa84d075fdd7

Parents:

8fee8407b328f6852dc1ff5372e3f43552ca5fe4

Message:

Fix: normalform for transext::ntDiv, Tests for transext

File:

• libpolys/polys/ext_fields/transext.cc (modified) (2 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -138 +138 @@
   assume(NUM(t) != NULL);   /**< t != 0 ==> numerator(t) != 0 */
   p_Test(NUM(t), ntRing);
-  if (!DENIS1(t)) p_Test(DEN(t), ntRing);
+  if (!DENIS1(t)) 
+  {
+    p_Test(DEN(t), ntRing);
+    if(p_IsConstant(DEN(t),ntRing) && (n_IsOne(pGetCoeff(DEN(t)),ntRing->cf)))
+    {
+      Print("?/1 in %s:%d\n",f,l);
+       return FALSE;
+    }
+  }
   return TRUE;
 }
@@ -561 +569 @@
   fraction result = (fraction)omAlloc0Bin(fractionObjectBin);
   NUM(result) = g;
-  DEN(result) = f;
+  if (!p_IsConstant(f,ntRing) || !n_IsOne(pGetCoeff(f),ntRing->cf))
+    DEN(result) = f;
   COM(result) = COM(fa) + COM(fb) + MULT_COMPLEXITY;
   heuristicGcdCancellation((number)result, cf);