Changeset 1427c5c in git

Timestamp:

Jan 27, 2020, 9:39:46 PM (4 years ago)

Author:

Karim Abou Zeid <karim23697@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

bbc88372fd4d9c3bc704e6afef375197fdd09810

Parents:

2857dfa8378694e81c473eaa4ec5ed50c7fba35a

Message:

Fix bug in ksReducePolyGCD() for Letterplace. The commutative team
should probably also look into this.

File:

• kernel/GBEngine/kspoly.cc (modified) (1 diff)

kernel/GBEngine/kspoly.cc

@@ -398 +398 @@
   {
     ct = n_ExtGcd(pGetCoeff(p1), pGetCoeff(p2), &an, &bn, tailRing->cf);    // Calculate GCD
+#ifdef HAVE_SHIFTBBA
+    if (n_IsZero(an, tailRing->cf) || n_IsZero(bn, tailRing->cf))
+    {
+      // NOTE: not sure why this is not checked in the commutative case, this *does* happen and then zero coeff errors are reported
+
+      // NOTE: we are probably leaking memory of lm=pOne(), but we cannot delete it since it could also be lm=p1
+      n_Delete(&an, tailRing->cf);
+      n_Delete(&bn, tailRing->cf);
+      n_Delete(&ct, tailRing->cf);
+      return ret;
+    }
+#endif
     /* negate bn since we subtract in Tail_Minus_mm_Mult_qq */
     bn  = n_InpNeg(bn, tailRing->cf);