Changeset 1c0d95 in git

Timestamp:

Jun 28, 2020, 3:34:10 PM (4 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

3ecc88f45ef1313dc0a3f042230c616aec77f588

Parents:

78242cd9e20b3bbe063e29767e95ac64f65545d6

Message:

fix: rOpposite for lp/rp

Files:

• Tst/Short/bug_opposite.res.gz.uu (added)
• Tst/Short/bug_opposite.stat (added)
• Tst/Short/bug_opposite.tst (added)
• Tst/Short/ok_s.lst (modified) (1 diff)
• libpolys/polys/monomials/ring.cc (modified) (9 diffs)

Tst/Short/ok_s.lst

@@ -17 +17 @@
 bug_newstruct3
 bug_normalize
+bug_opposite
 bug_OrdSgn
 bug_printres

libpolys/polys/monomials/ring.cc

@@ -5237 +5237 @@
 {
   /* works for commutative/Plural; need to be changed for Letterplace */
-  /* Letterpace: each block of vars needs to be reverted on it own */ 
+  /* Letterpace: each block of vars needs to be reverted on it own */
   int i2=(l+1)/2;
   for(int j=0; j<=i2; j++)
@@ -5264 +5264 @@
 #endif
 
-  ring r = rCopy0(src,FALSE); /* qideal will be deleted later on!!! */
+  ring r = rCopy0(src,FALSE);
+  if (src->qideal != NULL)
+  {
+    id_Delete(&(r->qideal), src);
+  }
 
   // change vars v1..vN -> vN..v1
@@ -5341 +5345 @@
 //  }
   // Change order/block structures (needed for rPrint, rAdd etc.)
-  
+
   int j=0;
   int l=rBlocks(src);
   if ( ! rIsLPRing(src) )
-  { 
+  {
     // ie Plural or commutative
     for(i=0; src->order[i]!=0; i++)
@@ -5360 +5364 @@
           r->block0[j]=rOppVar(r, src->block1[i]);
           r->block1[j]=rOppVar(r, src->block0[i]);
-          break;
+          j++;break;
         case ringorder_rp: /* rp -> lp */
           r->order[j]=ringorder_lp;
           r->block0[j]=rOppVar(r, src->block1[i]);
           r->block1[j]=rOppVar(r, src->block0[i]);
-          break;
+          j++;break;
         case ringorder_dp: /* dp -> a(1..1),ls */
         {
@@ -5482 +5486 @@
   } /* end if (!rIsLPRing(src)) */
   if (rIsLPRing(src))
-  { 
+  {
     // applies to Letterplace only
     // Letterplace conventions: dp<->Dp, lp<->rp
@@ -5500 +5504 @@
           r->block0[j]=rOppVar(r, src->block1[i]);
           r->block1[j]=rOppVar(r, src->block0[i]);
-          break;
+          j++;break;
         case ringorder_rp: /* rp -> lp */
           r->order[j]=ringorder_lp;
           r->block0[j]=rOppVar(r, src->block1[i]);
           r->block1[j]=rOppVar(r, src->block0[i]);
-          break;
+          j++;break;
         case ringorder_dp: /* dp -> Dp */
         {
@@ -5511 +5515 @@
           r->block0[j]=rOppVar(r, src->block1[i]);
           r->block1[j]=rOppVar(r, src->block0[i]);
+          j++;break;
         }
         case ringorder_Dp: /* Dp -> dp*/
@@ -5517 +5522 @@
           r->block0[j]=rOppVar(r, src->block1[i]);
           r->block1[j]=rOppVar(r, src->block0[i]);
+          j++;break;
         }
         // not clear how to do:
@@ -5607 +5613 @@
   if (src->qideal != NULL)
   {
-    id_Delete(&(r->qideal), r);
-
 #ifdef HAVE_PLURAL
     r->qideal = idOppose(src, src->qideal, r); // into the currRing: r