Changeset 1ca456 in git

Timestamp:

Nov 2, 2012, 2:30:28 PM (10 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'a800fe4b3e9d37a38c5a10cc0ae9dfa0c15a4ee6')

Children:

665ca84bd3cc340311b38ceff7974b3261b7a24e

Parents:

12777c5748c82636b06dbe5ed71f2459864064c1

Message:

fix: int overflow in interpreter

File:

• Singular/iparith.cc (modified) (1 diff)

Singular/iparith.cc

@@ -869 +869 @@
   int a=(int)(long)u->Data();
   int b=(int)(long)v->Data();
-  int c=a * b;
-  if ((b!=0) && (c/b !=a))
+  int64 c=(int64)a * (int64)b;
+  if ((c>INT_MAX)||(c<INT_MIN))
     WarnS("int overflow(*), result may be wrong");
-  res->data = (char *)((long)c);
+  res->data = (char *)((long)((int)c));
   if ((u->Next()!=NULL) || (v->Next()!=NULL))
     return jjOP_REST(res,u,v);