Changeset 2206753 in git for libpolys/polys/ext_fields/transext.cc

Timestamp:

Nov 29, 2014, 8:49:14 PM (9 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

8104914d2d708e24127bd8e7c8155a42a11e2ee4

Parents:

80b6d366c7d9906d194bdb7023d476a11e90d957

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2014-11-29 20:49:14+01:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2014-12-15 18:48:27+01:00

Message:

Hiding all the implementation details (or adding the counting) mostly by
moving internal declarations from private headers into corresponding source files

rm: Remove internal includes (hiding privates) + cleanup
chg: cleanup internal headers
fix the usage of internal implementation functions of coeffs from outside of libpolys/coeffs (or libpolys/polys/ext_fiels)
fix header includes for coeffs/AE*.{h,cc}
add: FIXME&TODO mark reused privates

also starting to fix bigint handling

File:

• libpolys/polys/ext_fields/transext.cc (modified) (6 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -1149 +1149 @@
       {
         c = p_GetCoeff(p, ntRing);
-        tmp = nlGcd(c, gcdOfCoefficients, ntCoeffs);
+        tmp = n_Gcd(c, gcdOfCoefficients, ntCoeffs);
         n_Delete(&gcdOfCoefficients, ntCoeffs);
         gcdOfCoefficients = tmp;
@@ -1158 +1158 @@
       {
         c = p_GetCoeff(p, ntRing);
-        tmp = nlGcd(c, gcdOfCoefficients, ntCoeffs);
+        tmp = n_Gcd(c, gcdOfCoefficients, ntCoeffs);
         n_Delete(&gcdOfCoefficients, ntCoeffs);
         gcdOfCoefficients = tmp;
@@ -1514 +1514 @@
     {
       pGcd = pa;
-      p_SetCoeff (pGcd, nlGcd (pGetCoeff(pGcd), pGetCoeff(pb), ntCoeffs), ntRing);
+      p_SetCoeff (pGcd, n_Gcd (pGetCoeff(pGcd), pGetCoeff(pb), ntCoeffs), ntRing);
     }
     else
@@ -1769 +1769 @@
     return res;
   }
-  number nn=nlGetDenom(a,src);
-  number zz=nlGetNumerator(a,src);
+  number nn=n_GetDenom(a,src);
+  number zz=n_GetNumerator(a,src);
   number res=ntInit(p_NSet(zz,dst->extRing), dst);
   fraction ff=(fraction)res;
@@ -1888 +1888 @@
   if (n_IsZero(a, src)) return NULL;
   // int p = rChar(dst->extRing);
-  number q = nlModP(a, src, dst->extRing->cf);
+
+  number q = nlModP(a, src, dst->extRing->cf); // FIXME? TODO? // extern number nlModP(number q, const coeffs Q, const coeffs Zp); // Map q \in QQ \to Zp
 
   if (n_IsZero(q, dst->extRing->cf))
@@ -2402 +2403 @@
 
   cf->factoryVarOffset = R->cf->factoryVarOffset + rVar(R);
-  extern char* naCoeffString(const coeffs r);
-  cf->cfCoeffString = naCoeffString;
+   
+  cf->cfCoeffString = naCoeffString; // FIXME? TODO? // extern char* naCoeffString(const coeffs r);
 
   cf->cfGreaterZero  = ntGreaterZero;