Changeset 2ca913e in git

Timestamp:

Jan 2, 2012, 1:04:00 PM (11 years ago)

Author:

Jan Engelhardt <jengelh@…>

Branches:

(u'spielwiese', 'f6c3dc58b0df4bd712574325fe76d0626174ad97')

Children:

f5c16a012d815b8103d999d02bd9111babe07f3b

Parents:

280286e6acf5c8f548db784d83f19277edc9280e

git-author:

Jan Engelhardt <jengelh@inai.de>2012-01-02 13:04:00+01:00

git-committer:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2012-12-06 20:20:37+01:00

Message:

src: avoid pointless p = p = p->next;

With "#define pIter(p) ((p) = (p)->next)", "p = pIter(p)" expands to
"p = p = p->next".

monomials/p_polys.cc: In function 'void p_Monic(spolyrec*, ring)':
monomials/p_polys.cc:1500:17: warning: operation on 'p' may be
undefined [-Wsequence-point]
mpr_base.cc: In function 'spolyrec* monomAt(spolyrec*, int)':
mpr_base.cc:729:67: warning: operation on 'iter' may be undefined
[-Wsequence-point]

File:

• numeric/mpr_base.cc (modified) (1 diff)

numeric/mpr_base.cc

@@ -727 +727 @@
   assume( i > 0 );
   poly iter= p;
-  for ( int j= 1; (j < i) && (iter!=NULL); j++ ) iter= pIter(iter);
+  for ( int j= 1; (j < i) && (iter!=NULL); j++ ) pIter(iter);
   return iter;
 }