Changeset 2d3091c in git for libpolys/polys/ext_fields/transext.cc

Timestamp:

Jul 5, 2011, 5:03:04 PM (13 years ago)

Author:

Frank Seelisch <seelisch@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

06df101aca2a40770d6d90cccc4cbdedcf52950a

Parents:

da49bc5ede2940b54c1e9f92022763151efa76e6

git-author:

Frank Seelisch <seelisch@mathematik.uni-kl.de>2011-07-05 17:03:04+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 12:39:12+01:00

Message:

test for trac ticket #308 with new implementation (result is instantaneous)

File:

• libpolys/polys/ext_fields/transext.cc (modified) (3 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -8 +8 @@
 *           Denoting the implemented coeffs object by cf, then these numbers
 *           are represented as quotients of polynomials in the polynomial
-*           ring K[t_1, .., t_s] represented by cf->algring.
+*           ring K[t_1, .., t_s] represented by cf->extring.
 */
 
@@ -615 +615 @@
   {
     fraction f = (fraction)a;
-    BOOLEAN useBrackets = (!p_IsConstant(NUM(f), ntRing)) && (!DENIS1(f));
+    BOOLEAN useBrackets = (!p_IsConstant(NUM(f), ntRing)) ||
+                          (!n_GreaterZero(p_GetCoeff(NUM(f), ntRing),
+                                          ntCoeffs));
     if (useBrackets) StringAppendS("(");
     p_String0(NUM(f), ntRing, ntRing);
@@ -622 +624 @@
     {
       StringAppendS("/");
-      useBrackets = !p_IsConstant(DEN(f), ntRing);
+      useBrackets = (!p_IsConstant(DEN(f), ntRing)) ||
+                    (!n_GreaterZero(p_GetCoeff(DEN(f), ntRing), ntCoeffs));
       if (useBrackets) StringAppendS("(");
       p_String0(DEN(f), ntRing, ntRing);