Changeset 2e7132 in git for libpolys/polys

Timestamp:

Apr 29, 2013, 11:37:21 AM (11 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '4a9821a93ffdc22a6696668bd4f6b8c9de3e6c5f')

Children:

ccb904bb634d071cbadd5d11141c512313839b46

Parents:

3c2c9540b63c2f11ed9fe4817807c8b3e5034318

Message:

fix: n_Normalize for rat. functions

File:

• libpolys/polys/ext_fields/transext.cc (modified) (5 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -183 +183 @@
       number n=pGetCoeff(p);
       n_Test(n,ntCoeffs);
+      if ((!(SR_HDL(n) & SR_INT))&&(n->s==0))
+      /* not normalized, just do for the following test*/
+      {
+        n_Normalize(pGetCoeff(p),ntCoeffs);
+        n=pGetCoeff(p);
+      }
       if (!(SR_HDL(n) & SR_INT))
       {
@@ -988 +994 @@
        then both the numerator and the denominator will be divided by the
        GCD of the a_alpha's and the c_beta's (if this GCD is != 1),
-   (3) if 'a' is - e.g. after having performed steps (1) and (2) - of the
-       form
-          (sum_alpha a_alpha * t^alpha)
-          -----------------------------
-                        c
-       with integers a_alpha, and c != 1, then 'a' will be replaced by
-       (sum_alpha a_alpha/c * t^alpha);
    this procedure does not alter COM(f) (this has to be done by the
    calling procedure);
@@ -1004 +1003 @@
   assume(!DENIS1(f));
 
-  if (!p_IsConstant(DEN(f), ntRing))
   { /* step (1); see documentation of this procedure above */
     p_Normalize(NUM(f), ntRing);
@@ -1038 +1036 @@
     }
     n_Delete(&lcmOfDenominators, ntCoeffs);
-    if (!p_IsConstant(DEN(f), ntRing))
+    if (DEN(f)!=NULL)
     { /* step (2); see documentation of this procedure above */
       p = NUM(f);
@@ -1072 +1070 @@
       n_Delete(&gcdOfCoefficients, ntCoeffs);
     }
-  }
-  if (p_IsConstant(DEN(f), ntRing) &&
-      (!n_IsOne(p_GetCoeff(DEN(f), ntRing), ntCoeffs)))
-  { /* step (3); see documentation of this procedure above */
-    number inverseOfDen = n_Invers(p_GetCoeff(DEN(f), ntRing), ntCoeffs);
-    NUM(f) = p_Mult_nn(NUM(f), inverseOfDen, ntRing);
-    n_Delete(&inverseOfDen, ntCoeffs);
-    p_Delete(&DEN(f), ntRing);
-    DEN(f) = NULL;
   }