Changeset 31b6f4 in git

Timestamp:

Jun 19, 2017, 4:08:07 PM (7 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

79841e040271f4c682a3e29432cf8297a10db0ac

Parents:

6ca7ce393b31f4c446396c8dc6eeb61a837b6eca

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2017-06-19 16:08:07+02:00

git-committer:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2017-06-19 16:26:26+02:00

Message:

fix: assign minpoly with denom.

Files:

• Singular/ipassign.cc (modified) (4 diffs)
• Tst/Short/bug_minpoly_frac.res.gz.uu (added)
• Tst/Short/bug_minpoly_frac.stat (added)
• Tst/Short/bug_minpoly_frac.tst (added)
• Tst/Short/ok_s.lst (modified) (1 diff)
• kernel/GBEngine/kstd1.cc (modified) (1 diff)

Singular/ipassign.cc

@@ -266 +266 @@
   if (DEN((fraction)(p)) != NULL) // minpoly must be a fraction with poly numerator...!!
   {
-    poly z=NUM((fraction)p);
     poly n=DEN((fraction)(p));
-    z=p_Mult_nn(z,pGetCoeff(n),currRing->cf->extRing);
-    NUM((fraction)p)=z;
+    if(!o_IsConstantPoly(n,currRing->cf->extRing))
+    {
+      WarnS("denominator must be constant - ignoring it");
+    }
+    p_Delete(&n,currRing->cf->extRing);
     DEN((fraction)(p))=NULL;
-    p_Delete(&n,currRing->cf->extRing);
   }
 
@@ -288 +289 @@
 //  NUM((fractionObject *)p) = NULL; // makes 0/ NULL fraction - which should not happen!
 //  n_Delete(&p, currRing->cf); // doesn't expect 0/ NULL :(
-  if(true)
   {
     extern omBin fractionObjectBin;
@@ -295 +295 @@
   }
 
-
   coeffs new_cf = nInitChar(n_algExt, &A);
-
   if (new_cf==NULL)
   {
@@ -309 +307 @@
     nKillChar(currRing->cf); currRing->cf=new_cf;
   }
-
-  return FALSE;
-}
+  return FALSE;
+}
+
 static BOOLEAN jjNOETHER(leftv, leftv a)
 {

Tst/Short/ok_s.lst

@@ -5 +5 @@
 bug_misc
 bug_minpoly
+bug_minpoly_frac
 bug_newstruct
 bug_normalize

kernel/GBEngine/kstd1.cc

@@ -2354 +2354 @@
         strat->homog=h;
       }
+      #ifdef ADIDEBUG
       else
       {
-        #ifdef ADIDEBUG
         printf("\npreIntegerCheck didn't found any new information\n");
-        #endif
-      }
+      }
+      #endif
       omTestMemory(1);
       if(w == NULL)