Changeset 36652d8 in git for factory/fac_sqrfree.cc

Timestamp:

Jun 26, 1996, 3:15:28 PM (27 years ago)

Author:

Rüdiger Stobbe <stobbe@…>

Branches:

(u'spielwiese', 'ec94ef7a30b928574c0c3daf41f6804dff5f6b69')

Children:

af4c5612a18aeb436641ed03ae4ea4fb66c029dc

Parents:

95f247516b202e419d274f3f954f152ab83c4184

Message:

"sqrFreeZ: Now handles the sign of the argument right.
"


git-svn-id: file:///usr/local/Singular/svn/trunk@29 2c84dea3-7e68-4137-9b89-c4e89433aadc

File:

• factory/fac_sqrfree.cc (modified) (3 diffs)

factory/fac_sqrfree.cc

@@ -1 +1 @@
 // emacs edit mode for this file is -*- C++ -*-
-// $Id: fac_sqrfree.cc,v 1.1 1996-05-20 13:39:48 stobbe Exp $
+// $Id: fac_sqrfree.cc,v 1.2 1996-06-26 13:15:28 stobbe Exp $
 
 #include "assert.h"
@@ -8 +8 @@
 /*
 $Log: not supported by cvs2svn $
+Revision 1.1  1996/05/20 13:39:48  stobbe
+"sqrFree: Now the product of all factors found by sqrFree is equal to the
+         parameter of sqrFree. The bug resulted from an incorrect handling
+         of the leading coefficient of the argument of sqrFree.
+"
+
 // Revision 1.0  1996/05/17  10:59:45  stobbe
 // Initial revision
@@ -128 +134 @@
         else
             F.append( CFFactor( w, i ) );
-    if ( ! cont.isOne() )
-        return Union( F, sqrFreeZ( cont ) );
-    else
-        return F;
+    if ( ! cont.isOne() && ! cont.inCoeffDomain() )
+        F = Union( F, sqrFreeZ( cont ) );
+    if ( lc( a ).sign() < 0 ) {
+        if ( F.getFirst().exp() == 1 ) {
+            CanonicalForm f = F.getFirst().factor();
+            CFFListIterator(F).getItem() = CFFactor( -f, 1 );
+        }
+        else
+            F.insert( CFFactor( -1, 1 ) );
+    }
+    return F;
 }