Changeset 37c7fc1 in git for libpolys/polys/monomials

Timestamp:

May 19, 2011, 8:45:43 PM (13 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

09ed7738e7d4dd96c01950a6f0736d8581f333d2

Parents:

4a2260efc22c19ac8eaf58d529af8decbb9420bb

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2011-05-19 20:45:43+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 12:36:13+01:00

Message:

FIX: fixed a memory double destruction bug in p_Monic

File:

• libpolys/polys/monomials/p_polys.cc (modified) (1 diff)

libpolys/polys/monomials/p_polys.cc

@@ -1483 +1483 @@
   number lc = p_GetCoeff(p, r);
   if (n_IsOne(lc, r->cf)) return;
-  number n = n_Init(1, r->cf);
-  p_SetCoeff(p, n, r);
+
+  if( pNext(p) == NULL )
+  { 
+     p_SetCoeff(p, n_Init(1, r->cf), r); // will delete the leading coeff 1st!
+     return;
+  }
+   
+  // TODO: consider unsing 1xn_Inverse + n_Mult instead of multiple n_Div
+  p_SetCoeff0(p, n_Init(1, r->cf), r); // no coeff destruction!
+   
   p = pIter(p);
+   
   while (p != NULL)
   {