Changeset 37f64cb in git for factory

Timestamp:

Nov 10, 2014, 2:11:54 PM (9 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '17f1d200f27c5bd38f5dfc6e8a0879242279d1d8')

Children:

15fcb38bebbcb70530db90de874d580d783a12b9

Parents:

fe24d605f70f42e77d679a658b67497779c85ae7

Message:

fix: tr.#666: factorize

File:

• factory/facFactorize.cc (modified) (1 diff)

factory/facFactorize.cc

@@ -279 +279 @@
   A *= bCommonDen (A);
   CFList Aeval, list, evaluation, bufEvaluation, bufAeval;
-  int factorNums= 1;
+  int factorNums= 2;
+  //p is irreducible. But factorize does not recognizes this. However, if you
+  //change factorNums to 2 at line 281 in facFactorize.cc it will. That change
+  //might impair performance in some cases since you do twice as many
+  //bivariate factorizations as before. Otherwise you need to change
+  //precomputeLeadingCoeff to detect these cases and trigger more bivariate
+  // factorizations.
+  // (http://www.singular.uni-kl.de:8002/trac/ticket/666)
   CFList biFactors, bufBiFactors;
   CanonicalForm evalPoly;