Changeset 3b1d9a in git

Timestamp:

Aug 10, 2011, 6:03:37 PM (12 years ago)

Author:

Burcin Erocal <burcin@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'f875bbaccd0831e36aaed09ff6adeb3eb45aeb94')

Children:

7b2b05e5e54bc3ab322d7d747d4f5afdd8352050

Parents:

1085d42039758a8ec5ff857d7c0b1d53388050e6

git-author:

Burcin Erocal <burcin@erocal.org>2011-08-10 18:03:37+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 13:18:26+01:00

Message:

Convert Singular/maps_ip.cc to libpolys.

Files:

• Singular/ipassign.cc (modified) (9 diffs)
• Singular/maps_ip.cc (modified) (12 diffs)
• libpolys/polys/polys.h (modified) (1 diff)

Singular/ipassign.cc

@@ -17 +17 @@
 #include <misc/options.h>
 #include <Singular/ipid.h>
-#include <kernel/idrec.h>
+#include <Singular/idrec.h>
 #include <misc/intvec.h>
 #include <omalloc/omalloc.h>
@@ -30 +30 @@
 #include <Singular/lists.h>
 #include <coeffs/numbers.h>
-#include <kernel/longalg.h>
+#include <polys/ext_fields/longalg.h>
 #include <kernel/stairc.h>
 #include <polys/monomials/maps.h>
@@ -39 +39 @@
 #include <Singular/silink.h>
 #include <Singular/ipshell.h>
-#include <kernel/sca.h>
+#include <polys/nc/sca.h>
 #include <Singular/blackbox.h>
 
@@ -131 +131 @@
     {
       poly p=(poly)IDDATA(h);
-      IDDATA(h)=(char*)pMinPolyNormalize(p);
+      IDDATA(h)=(char*)p_MinPolyNormalize(p, currRing);
       break;
     }
@@ -141 +141 @@
       int i;
       ideal I=(ideal)IDDATA(h);
-      for(i=IDELEMS(I)-1;i>=0;i--) I->m[i]=pMinPolyNormalize(I->m[i]);
+      for(i=IDELEMS(I)-1;i>=0;i--)
+              I->m[i]=p_MinPolyNormalize(I->m[i], currRing);
       break;
     }
@@ -169 +170 @@
   {
     if ((rPar(currRing)!=1)
-      || (rField_is_GF()))
+      || (rField_is_GF(currRing)))
     {
       WerrorS("no minpoly allowed");
@@ -486 +487 @@
   if (res->data!=NULL) idDelete((ideal*)&res->data);
   res->data=(void *)a->CopyD(MATRIX_CMD);
-  if (a->rtyp==IDHDL) idNormalize((ideal)a->Data());
-  else                idNormalize((ideal)res->data);
+  if (a->rtyp==IDHDL) id_Normalize((ideal)a->Data(), currRing);
+  else                id_Normalize((ideal)res->data, currRing);
   jiAssignAttr(res,a);
   if (((res->rtyp==IDEAL_CMD)||(res->rtyp==MODUL_CMD))
@@ -529 +530 @@
   ((ideal)m)->rank=1;
   MATROWS(m)=1;
-  idNormalize((ideal)m);
+  id_Normalize((ideal)m, currRing);
   res->data=(void *)m;
   if (TEST_V_QRING && (currQuotient!=NULL)) jjNormalizeQRingId(res);
@@ -579 +580 @@
   res->data=(void *)a->CopyD(IDEAL_CMD);
   f=(map)res->data;
-  idNormalize((ideal)f);
+  id_Normalize((ideal)f, currRing);
   f->preimage = rn;
   return FALSE;

Singular/maps_ip.cc

@@ -10 +10 @@
 
 #include "maps_ip.h"
+#include "ipid.h"
 
 #include <omalloc/omalloc.h>
@@ -18 +19 @@
 #include <polys/matpol.h>
 #include <polys/prCopy.h>
+#include <libpolys/polys/ext_fields/longtrans.h>
+#include <libpolys/polys/monomials/maps.h>
+#include <libpolys/coeffs/coeffs.h>
 
 // #include <kernel/longalg.h>
@@ -63 +67 @@
         res->data=(void *)napPermNumber((number)data,par_perm,P, preimage_r);
         res->rtyp=POLY_CMD;
-        if (currRing->minpoly!=NULL)
-          res->data=(void *)pMinPolyNormalize((poly)res->data);
+        if (nCoeff_is_Extension(currRing->cf))
+          res->data=(void *)p_MinPolyNormalize((poly)res->data, currRing);
         pTest((poly) res->data);
       }
       else
       {
-        res->data=(void *)nMap((number)data);
-        if (currRing->minpoly!=NULL)
+        res->data=(void *)nMap((number)data, preimage_r->cf, currRing->cf);
+        if (nCoeff_is_Extension(currRing->cf))
         {
           number a=(number)res->data;
@@ -86 +90 @@
     case POLY_CMD:
     case VECTOR_CMD:
-      if ((what==FETCH_CMD)&& (nMap==nCopy))
-        res->data=(void *)prCopyR( (poly)data, preimage_r);
+      if ((what==FETCH_CMD)&& (preimage_r->cf==currRing->cf))
+        res->data=(void *)prCopyR( (poly)data, preimage_r, currRing);
       else
       if ((what==IMAP_CMD) || ((what==FETCH_CMD) /* && (nMap!=nCopy)*/))
-        res->data=(void *)pPermPoly((poly)data,perm,preimage_r,nMap,par_perm,P);
+        res->data=(void *)p_PermPoly((poly)data,perm,preimage_r,currRing,
+                        nMap,par_perm,P);
       else /*if (what==MAP_CMD)*/
       {
         matrix s=mpNew(N,maMaxDeg_P((poly)data, preimage_r));
-        res->data=(void *)maEval(theMap,(poly)data,preimage_r,nMap,s);
+        res->data=(void *)maEval(theMap,(poly)data,preimage_r,nMap,(ideal)s);
         idDelete((ideal *)&s);
       }
-      if (currRing->minpoly!=NULL)
-        res->data=(void *)pMinPolyNormalize((poly)res->data);
+      if (nCoeff_is_Extension(currRing->cf))
+        res->data=(void *)p_MinPolyNormalize((poly)res->data, currRing);
       pTest((poly)res->data);
       break;
@@ -117 +122 @@
         ((matrix)data)->rank=((matrix)data)->rows();
       }
-      if ((what==FETCH_CMD)&& (nMap==nCopy))
+      if ((what==FETCH_CMD)&& (preimage_r->cf == currRing->cf))
       {
         for (i=R*C-1;i>=0;i--)
         {
-          m->m[i]=prCopyR(((ideal)data)->m[i], preimage_r);
+          m->m[i]=prCopyR(((ideal)data)->m[i], preimage_r, currRing);
           pTest(m->m[i]);
         }
@@ -130 +135 @@
         for (i=R*C-1;i>=0;i--)
         {
-          m->m[i]=pPermPoly(((ideal)data)->m[i],perm,preimage_r,nMap,par_perm,P);
+          m->m[i]=p_PermPoly(((ideal)data)->m[i],perm,preimage_r,currRing,
+                          nMap,par_perm,P);
           pTest(m->m[i]);
         }
@@ -139 +145 @@
         for (i=R*C-1;i>=0;i--)
         {
-          m->m[i]=maEval(theMap,((ideal)data)->m[i],preimage_r,nMap,s);
+          m->m[i]=maEval(theMap,((ideal)data)->m[i],preimage_r,nMap,(ideal)s);
           pTest(m->m[i]);
         }
         idDelete((ideal *)&s);
       }
-      if (currRing->minpoly!=NULL)
+      if (nCoeff_is_Extension(currRing->cf))
       {
         for (i=R*C-1;i>=0;i--)
         {
-          m->m[i]=pMinPolyNormalize(m->m[i]);
+          m->m[i]=p_MinPolyNormalize(m->m[i], currRing);
           pTest(m->m[i]);
         }
@@ -208 +214 @@
 {
   ideal theMapI=idInit(rPar(currRing),1);
-  nMapFunc nMap=nSetMap(currRing->extRing);
+  nMapFunc nMap=n_SetMap(currRing->cf->extRing->cf, currRing->cf->extRing->cf);
 
   int i;
@@ -218 +224 @@
       pp=theMapI->m[i-1]=pOne();
       lnumber n=(lnumber)pGetCoeff(pp);
-      p_SetExp(n->z,i,1,currRing->extRing);
-      p_Setm(n->z,currRing->extRing);
+      p_SetExp(n->z,i,1,currRing->cf->extRing);
+      p_Setm(n->z,currRing->cf->extRing);
     }
     else
@@ -239 +245 @@
     tmpW.data=n->z;
     if (n->n!=NULL) WarnS("ignoring denominators of coefficients...");
-    if (maApplyFetch(MAP_CMD,theMap,v,&tmpW,currRing->extRing,NULL,NULL,0,nMap))
+    if (maApplyFetch(MAP_CMD,theMap,v,&tmpW,currRing->cf->extRing,NULL,NULL,0,nMap))
     {
       WerrorS("map failed");
@@ -312 +318 @@
     tmpW.data=p;
     leftv v=(leftv)omAlloc0Bin(sleftv_bin);
-    if (maApplyFetch(MAP_CMD,theMap,v,&tmpW,currRing,NULL,NULL,0,nCopy))
+    if (maApplyFetch(MAP_CMD,theMap,v,&tmpW,currRing,NULL,NULL,0,
+                            n_SetMap(currRing->cf, currRing->cf)))
     {
       WerrorS("map failed");
@@ -354 +361 @@
   tmpW.rtyp=IDEAL_CMD;
   tmpW.data=id;
-  if (maApplyFetch(MAP_CMD,theMap,v,&tmpW,currRing,NULL,NULL,0,nCopy))
+  if (maApplyFetch(MAP_CMD,theMap,v,&tmpW,currRing,NULL,NULL,0,
+                          n_SetMap(currRing->cf, currRing->cf)))
   {
     WerrorS("map failed");

libpolys/polys/polys.h

@@ -327 +327 @@
 
 
-#define   pSubst(p,n,e) p_Subst(p,n.e,currRing)
+#define   pSubst(p,n,e) p_Subst(p,n,e,currRing)
 #define   ppJet(p,m) pp_Jet(p,m,currRing)
 #define   pJet(p,m)  p_Jet(p,m,currRing)