Changeset 3ff2cf in git

Timestamp:

May 9, 2014, 12:36:05 PM (10 years ago)

Author:

Martin Lee <martinlee84@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

082428606ab86c928fbf217217338a788f266009

Parents:

86824086279291ea10cc7d98f86c05680d743c24

git-author:

Martin Lee <martinlee84@web.de>2014-05-09 12:36:05+02:00

git-committer:

Martin Lee <martinlee84@web.de>2014-05-12 14:35:03+02:00

Message:

chg: better docu of sqrf_norm

File:

• factory/facAlgFunc.cc (modified) (4 diffs)

factory/facAlgFunc.cc

@@ -197 +197 @@
 }
 
-// sqr-free routine for algebraic extensions
-// we need it! Ex.: f=c^2+2*a*c-1; as=[a^2+1]; f=(c+a)^2
-//static CFFList alg_sqrfree( const CanonicalForm & f )
-//{
-//  CFFList L;
-//
-//  L.append(CFFactor(f,1));
-//  return L;
-//}
-
-// Calculates a square free norm
-// Input: f(x, alpha) a square free polynomial over K(alpha),
+// Trager's square free norm algorithm:
+// f a separable polynomial over K (alpha),
 // alpha is defined by the minimal polynomial Palpha
-// K has more than S elements (S is defined in thesis; look getDegOfExt)
+// K need to contain more than S elements (S is defined in Messollen's thesis;
+// see also getDegOfExt)
 static CFFList
 sqrf_norm_sub (const CanonicalForm & f, const CanonicalForm & PPalpha,
@@ -279 +270 @@
 {
   CFFList result;
-  if ( getCharacteristic() == 0 )
+  if (getCharacteristic() == 0)
   {
     IntGenerator myrandom;
     result= sqrf_norm_sub (f, PPalpha, myrandom, s, g, R);
   }
-  else if ( degree (Extension) > 0 ) // working over Extensions
+  else if (degree (Extension) > 0)
   {
     AlgExtGenerator myrandom (Extension);
@@ -298 +289 @@
 
 // calculate a "primitive element"
-// K must have more than S elements (->thesis, -> getDegOfExt)
+// K must have more than S elements (-> getDegOfExt)
 static CFList
 simpleExtension(CFList& backSubst, const CFList & Astar,
@@ -321 +312 @@
     R=Bstar.getFirst();
     Bstar.removeFirst();
-    for (CFListIterator i=Bstar; i.hasItem(); i++)
+    for (CFListIterator i= Bstar; i.hasItem(); i++)
     {
       j= i;