Changeset 4254a7f in git for libpolys

Timestamp:

Sep 16, 2013, 4:55:47 PM (11 years ago)

Author:

Martin Lee <martinlee84@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

e3572aeabbaf031b22dbbac237937700676a8248

Parents:

12d61707b29797f7bf3e42e5b9f0a01e937da42b

git-author:

Martin Lee <martinlee84@web.de>2013-09-16 16:55:47+02:00

git-committer:

Martin Lee <martinlee84@web.de>2013-09-27 11:27:58+02:00

Message:

chg: make denominator monic if over a transcendental field extension of a finite field

File:

• libpolys/polys/ext_fields/transext.cc (modified) (2 diffs)

libpolys/polys/ext_fields/transext.cc

@@ -1387 +1387 @@
        DEN(f), or both, due to previous arithmetics. The next call will
        remove those nested fractions, in case there are any. */
-    if (nCoeff_is_Zp(ntCoeffs) && p_IsConstant (DEN (f), ntRing))
+    if (nCoeff_is_Zp(ntCoeffs))
     {
       NUM (f) = p_Div_nn (NUM (f), p_GetCoeff (DEN(f),ntRing), ntRing);
-      p_Delete(&DEN (f), ntRing);
-      DEN (f) = NULL;
-      COM (f) = 0;
+      if (p_IsConstant (DEN (f), ntRing))
+      {
+        p_Delete(&DEN (f), ntRing);
+        DEN (f) = NULL;
+      }
+      else
+      {
+        p_Norm (DEN (f),ntRing);
+      }
     } else if (nCoeff_is_Q(ntCoeffs)) handleNestedFractionsOverQ(f, cf);
   }
@@ -1407 +1413 @@
     else
     {
-      if (nCoeff_is_Zp(ntCoeffs) && p_IsConstant (DEN (f), ntRing))
+      if (nCoeff_is_Zp(ntCoeffs))
       {
         NUM (f) = p_Div_nn (NUM (f), p_GetCoeff (DEN(f),ntRing), ntRing);
-        p_Delete(&DEN (f), ntRing);
-        DEN (f) = NULL;
-        COM (f) = 0;
+        if (p_IsConstant (DEN (f), ntRing))
+        {
+          p_Delete(&DEN (f), ntRing);
+          DEN (f) = NULL;
+        }
+        else
+        {
+          p_Norm (DEN (f),ntRing);
+        }
       }
     }