Changeset 4a7a45 in git

Timestamp:

Jul 29, 2020, 5:33:12 PM (3 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'd1ba061a762c62d3a25159d8da8b6e17332291fa')

Children:

700b89d0131c4b3d214f49af1eeb67501875ec89

Parents:

4772b1b4621f2ab68acc9d2b5a568604d4d5e790

Message:

fix: factorize in Z[x,..] w/o NTL

Location:

factory

Files:

• canonicalform.cc (modified) (6 diffs)
• canonicalform.h (modified) (1 diff)
• cf_binom.h (modified) (1 diff)
• cf_factory.cc (modified) (3 diffs)
• cf_factory.h (modified) (2 diffs)
• fac_distrib.cc (modified) (2 diffs)
• fac_distrib.h (modified) (1 diff)
• fac_multihensel.cc (modified) (7 diffs)
• fac_multivar.cc (modified) (9 diffs)
• fac_multivar.h (modified) (1 diff)
• int_pp.h (modified) (2 diffs)

factory/canonicalform.cc

@@ -15 +15 @@
 #include "cf_algorithm.h"
 #include "imm.h"
+#include "int_pp.h"
 #include "gfops.h"
 #include "facMul.h"
 #include "facAlgFuncUtil.h"
 #include "FLINTconvert.h"
+#include "cf_binom.h"
 
 #ifndef NOSTREAMIO
@@ -204 +206 @@
 }
 
+
 CanonicalForm
 CanonicalForm::mapinto () const
@@ -216 +219 @@
             else
                 return *this;
+        else  if ( CFFactory::gettype() == PrimePowerDomain )
+            return CanonicalForm( CFFactory::basic( imm2int( value ) ) );
         else  if ( getGFDegree() == 1 )
             return CanonicalForm( int2imm_p( ff_norm( imm2int( value ) ) ) );
@@ -222 +227 @@
     else  if ( value->inBaseDomain() )
         if ( getCharacteristic() == 0 )
-             return *this;
+            if ( value->levelcoeff() == PrimePowerDomain )
+            {
+              mpz_t d;
+              getmpi( value,d);
+              if ( mpz_cmp( InternalPrimePower::primepowhalf, d ) < 0 )
+                mpz_sub( d, d, InternalPrimePower::primepow );
+              return CFFactory::basic( d );
+            }
+            else
+                return *this;
+        else  if ( CFFactory::gettype() == PrimePowerDomain )
+        {
+            ASSERT( value->levelcoeff() == PrimePowerDomain || value->levelcoeff() == IntegerDomain, "no proper map defined" );
+            if ( value->levelcoeff() == PrimePowerDomain )
+                return *this;
+            else
+            {
+              mpz_t d;
+              getmpi(value,d);
+              if ( mpz_cmp( InternalPrimePower::primepowhalf, d ) < 0 )
+                mpz_sub( d, d, InternalPrimePower::primepow );
+              return CFFactory::basic( d );
+            }
+        }
         else
         {
@@ -248 +276 @@
     }
 }
-
 /** CanonicalForm CanonicalForm::lc (), Lc (), LC (), LC ( v ) const
  *
@@ -1935 +1962 @@
     return cf_glob_switches.isOn( sw );
 }
+
+#ifndef HAVE_NTL
+static int initialized=0;
+int
+initCanonicalForm( void )
+{
+  if ( ! initialized )
+  {
+    initPT();
+    initialized = true;
+  }
+}
+#endif
+

factory/canonicalform.h

@@ -404 +404 @@
 /*ENDPUBLIC*/
 
+int initCanonicalForm( void );
+static int cf_is_initialized_now = initCanonicalForm();
 #endif /* ! INCL_CANONICALFORM_H */

factory/cf_binom.h

@@ -1 +1 @@
 /* emacs edit mode for this file is -*- C++ -*- */
+/* $Id: cf_binom.h 12231 2009-11-02 10:12:22Z hannes $ */
 
 #ifndef INCL_CF_BINOM_H
 #define INCL_CF_BINOM_H
 
-// #include "config.h"
+#include <config.h>
 
 #include "canonicalform.h"

factory/cf_factory.cc

@@ -14 +14 @@
 #include "int_rat.h"
 #include "int_poly.h"
+#include "int_pp.h"
 #include "imm.h"
 
@@ -46 +47 @@
     case GaloisFieldDomain:
         return int2imm_gf( gf_int2gf( value ) );
+    case PrimePowerDomain:
+        return new InternalPrimePower( value );
     default: {
         ASSERT( 0, "illegal basic domain!" );
@@ -260 +263 @@
 void getmpi ( InternalCF * value, mpz_t mpi)
 {
-    ASSERT( ! is_imm( value ) && (value->levelcoeff() == IntegerDomain ), "illegal operation" );
+    ASSERT( ! is_imm( value ) && (value->levelcoeff() == IntegerDomain || value->levelcoeff() == PrimePowerDomain), "illegal operation" );
     mpz_init_set (mpi, ((InternalInteger*)value)->thempi);
 }
-

factory/cf_factory.h

@@ -29 +29 @@
     static void settype ( int type )
     {
-      ASSERT( type==FiniteFieldDomain || type==GaloisFieldDomain || type==IntegerDomain || type==RationalDomain, "illegal basic domain!" );
+      ASSERT( type==FiniteFieldDomain || type==GaloisFieldDomain || type==IntegerDomain || type==RationalDomain || type==PrimePowerDomain, "illegal basic domain!" );
       currenttype = type;
     };
@@ -46 +46 @@
 
 void getmpi ( InternalCF * value, mpz_t mpi);
-
 #endif /* ! INCL_CF_FACTORY_H */

factory/fac_distrib.cc

@@ -1 +1 @@
 /* emacs edit mode for this file is -*- C++ -*- */
-
-
-#include "config.h"
-
-
-#include "cf_assert.h"
+/* $Id: fac_distrib.cc 14344 2011-07-25 14:08:17Z mlee $ */
+
+#include <config.h>
+
+#include "assert.h"
 #include "debug.h"
 
@@ -16 +15 @@
 
 #ifndef HAVE_NTL
+
 bool
 nonDivisors ( CanonicalForm omega, CanonicalForm delta, const CFArray & F, CFArray & d )

factory/fac_distrib.h

@@ -1 +1 @@
 /* emacs edit mode for this file is -*- C++ -*- */
+/* $Id: fac_distrib.h 12231 2009-11-02 10:12:22Z hannes $ */
 
 #ifndef INCL_FAC_DISTRIB_H
 #define INCL_FAC_DISTRIB_H
 
-// #include "config.h"
+#include <config.h>
 
 #include "canonicalform.h"

factory/fac_multihensel.cc

@@ -1 +1 @@
 /* emacs edit mode for this file is -*- C++ -*- */
-
-
-#include "config.h"
-
-
-#include "cf_assert.h"
+/* $Id: fac_multihensel.cc 12231 2009-11-02 10:12:22Z hannes $ */
+
+#include <config.h>
+
+#include "assert.h"
 #include "debug.h"
 #include "timing.h"
@@ -14 +13 @@
 #include "fac_util.h"
 #include "fac_iterfor.h"
-#include "fac_multihensel.h"
 #include "cf_iter.h"
 
 #ifndef HAVE_NTL
 
-TIMING_DEFINE_PRINT(fac_solve)
-TIMING_DEFINE_PRINT(fac_modpk)
-TIMING_DEFINE_PRINT(fac_corrcoeff)
-TIMING_DEFINE_PRINT(fac_extgcd)
+TIMING_DEFINE_PRINT(fac_solve);
+TIMING_DEFINE_PRINT(fac_modpk);
+TIMING_DEFINE_PRINT(fac_corrcoeff);
+TIMING_DEFINE_PRINT(fac_extgcd);
 
 static void
-extgcdrest ( const CanonicalForm & a, const CanonicalForm & b, const CanonicalForm & s, const CanonicalForm & t, const CanonicalForm & c, CanonicalForm & S, CanonicalForm & T, const modpk & /*pk*/ )
+extgcdrest ( const CanonicalForm & a, const CanonicalForm & b, const CanonicalForm & s, const CanonicalForm & t, const CanonicalForm & c, CanonicalForm & S, CanonicalForm & T, const modpk & pk )
 {
     CanonicalForm sigma = s * c, tau = t * c;
@@ -169 +167 @@
         A[i] = remainder( pk( a[i] * C0 ), P0[i], pk );
     DEBOUTLN( cerr, "the first approximation of the correction coefficients is " << A );
-/*#ifdef DEBUGOUTPUT
+#ifdef DEBUGOUTPUT
     if ( check_dummy( A, P, Q ) - C != 0 )
     {
@@ -177 +175 @@
         DEBOUTLN( cerr, "              Q " << Q );
     }
-#endif*/
+#endif
     for ( m = 0; m <= h && ( m == 0 || Dm != 0 ); m++ )
     {
@@ -219 +217 @@
         DEBOUTLN( cerr, "the correction coefficients at step " << m );
         DEBOUTLN( cerr, "are now " << A );
-/*#ifdef DEBUGOUTPUT
+#ifdef DEBUGOUTPUT
     if ( check_dummy( A, P, Q ) - C != 0 ) {
         DEBOUTLN( cerr, "there is an error detected, the correction coefficients do not" );
@@ -226 +224 @@
         DEBOUTLN( cerr, "              Q " << Q );
     }
-#endif*/
+#endif
     }
     DEBDECLEVEL( cerr, "findCorrCoeffs" );
@@ -326 +324 @@
 
 bool
-Hensel ( const CanonicalForm & U, CFArray & G, const CFArray & lcG, const Evaluation & A, const modpk & bound, const Variable & /*x*/ )
+Hensel ( const CanonicalForm & U, CFArray & G, const CFArray & lcG, const Evaluation & A, const modpk & bound, const Variable & x )
 {
     DEBINCLEVEL( cerr, "Hensel" );

factory/fac_multivar.cc

@@ -1 +1 @@
 /* emacs edit mode for this file is -*- C++ -*- */
-
-
-#include "config.h"
-
-
-#include "cf_assert.h"
+/* $Id: fac_multivar.cc 14377 2011-09-01 13:40:30Z mlee $ */
+
+#include <config.h>
+
+#include "assert.h"
 #include "debug.h"
 #include "timing.h"
@@ -21 +20 @@
 #include "fac_distrib.h"
 #include "fac_multihensel.h"
+#include "facBivar.h"
 
 #ifndef HAVE_NTL
+
 void out_cf(const char *s1,const CanonicalForm &f,const char *s2);
 void out_cff(CFFList &L);
 
-TIMING_DEFINE_PRINT(fac_content)
-TIMING_DEFINE_PRINT(fac_findeval)
-TIMING_DEFINE_PRINT(fac_distrib)
-TIMING_DEFINE_PRINT(fac_hensel)
+TIMING_DEFINE_PRINT(fac_content);
+TIMING_DEFINE_PRINT(fac_findeval);
+TIMING_DEFINE_PRINT(fac_distrib);
+TIMING_DEFINE_PRINT(fac_hensel);
 
 static CFArray
@@ -69 +70 @@
 
 static modpk
-coeffBound ( const CanonicalForm & f, int p )
+coeffBound_old ( const CanonicalForm & f, int p )
 {
     int * degs = degrees( f );
@@ -148 +149 @@
 }
 
-#ifdef HAVE_NTL
-VAR int prime_number=0;
+
+static int prime_number=0;
 void find_good_prime(const CanonicalForm &f, int &start)
 {
@@ -199 +200 @@
   }
 }
-#endif
-
 static CFArray ZFactorizeMulti ( const CanonicalForm & arg )
 {
+    prime_number=0;
+    bool is_rat=isOn(SW_RATIONAL);
+    Off(SW_RATIONAL);
     DEBINCLEVEL( cerr, "ZFactorizeMulti" );
     CFMap M;
@@ -264 +266 @@
         G = conv_to_factor_array( factorize( U0, false ) );
         DEBOUTLN( cerr, "which factorizes into " << G );
-        #ifdef HAVE_NTL
         {
           int i=prime_number;
@@ -279 +280 @@
           else if (((i==0)||(i!=prime_number)))
           {
-            b = coeffBound( U, p );
+            b = coeffBound_old( U, p );
             prime_number=i;
           }
           // p!=0:
-          modpk bb=coeffBound(U0,p);
+          modpk bb=coeffBound_old(U0,p);
           if (bb.getk() > b.getk() ) b=bb;
-          bb=coeffBound(arg,p);
+          bb=coeffBound_old(arg,p);
           if (bb.getk() > b.getk() ) b=bb;
         }
-        #else
-        b = coeffBound( U, getZFacModulus().getp() );
         if ( getZFacModulus().getpk() > b.getpk() )
             b = getZFacModulus();
-        #endif
         //printf("p=%d, k=%d\n",b.getp(),b.getk());
         DEBOUTLN( cerr, "the coefficient bound of the factors of U is " << b.getpk() );
@@ -342 +340 @@
         G[1] = -G[1];
     DEBDECLEVEL( cerr, "ZFactorMulti" );
+    if(is_rat) On(SW_RATIONAL);
     return G;
 }
@@ -364 +363 @@
     {
         if ( i.getItem().factor().inCoeffDomain() )
-            R.append( CFFactor( i.getItem().factor(), i.getItem().exp() ) );
+        {
+            if ( ! i.getItem().factor().isOne() )
+                R.append( CFFactor( i.getItem().factor(), i.getItem().exp() ) );
+        }
         else
         {

factory/fac_multivar.h

@@ -1 +1 @@
 /* emacs edit mode for this file is -*- C++ -*- */
+/* $Id: fac_multivar.h 12231 2009-11-02 10:12:22Z hannes $ */
 
 #ifndef INCL_FAC_MULTIVAR_H
 #define INCL_FAC_MULTIVAR_H
 
-// #include "config.h"
+#include <config.h>
 
 #include "canonicalform.h"

factory/int_pp.h

@@ -30 +30 @@
     STATIC_VAR int prime;
     STATIC_VAR int exp;
+    static void initialize();
+public:
+    mpz_ptr MPI( const InternalCF * const c );
     STATIC_VAR mpz_t primepow;
     STATIC_VAR mpz_t primepowhalf;
-    static void initialize();
-    static mpz_ptr MPI( const InternalCF * const c );
-public:
     InternalPrimePower();
     InternalPrimePower( const InternalCF& )
@@ -91 +91 @@
 
     int sign() const;
-    friend mpz_ptr getmpi ( InternalCF * value, bool symmetric );
+    friend void getmpi ( InternalCF * value, mpz_t );
 };