Changeset 4d94c97 in git for libpolys/polys/ext_fields/algext.cc

Timestamp:

Mar 15, 2012, 7:43:06 PM (12 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'e7cc1ebecb61be8b9ca6c18016352af89940b21a')

Children:

da0565bb9765186b7c8bde819d2ea3522f22e26f

Parents:

90934a9f682716f4e6fe4afb6c7eb7b8f281b8bf

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-03-15 19:43:06+01:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-03-16 19:36:36+01:00

Message:

improved n[at]CoeffIsEqual

chg: they should test the *equality* of underlying rings,
e.g. in order to assure the coeffs of the following rings are the same:Q(P)[X],Q(P)[Y]

File:

• libpolys/polys/ext_fields/algext.cc (modified) (1 diff)

libpolys/polys/ext_fields/algext.cc

@@ -521 +521 @@
      registered cf and perform reference counting rather than creating
      multiple copies of the same coefficient field/domain/ring */
-  return (naRing == e->r);
+  if (naRing == e->r)
+    return TRUE;
   /* (Note that then also the minimal ideals will necessarily be
      the same, as they are attached to the ring.) */
+
+  // NOTE: Q(a)[x] && Q(a)[y] should better share the _same_ Q(a)...
+  if( rEqual(naRing, e->r, TRUE) )
+  {
+    const ideal mi = naRing->minideal; 
+    assume( IDELEMS(mi) == 1 );
+    ideal ii = e->i;
+    assume( IDELEMS(ii) == 1 );
+
+    // TODO: the following should be extended for 2 *equal* rings...
+    if( p_EqualPolys(mi->m[0], ii->m[0], naRing, e->r) )
+    {
+      id_Delete(&ii, e->r);
+      rDelete(e->r);
+      return TRUE;
+    }
+  }
+
+  return FALSE;  
+  
 }