Changeset 4d94c97 in git for libpolys/polys/ext_fields/transext.cc

Timestamp:

Mar 15, 2012, 7:43:06 PM (12 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'e7cc1ebecb61be8b9ca6c18016352af89940b21a')

Children:

da0565bb9765186b7c8bde819d2ea3522f22e26f

Parents:

90934a9f682716f4e6fe4afb6c7eb7b8f281b8bf

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-03-15 19:43:06+01:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-03-16 19:36:36+01:00

Message:

improved n[at]CoeffIsEqual

chg: they should test the *equality* of underlying rings,
e.g. in order to assure the coeffs of the following rings are the same:Q(P)[X],Q(P)[Y]

File:

• libpolys/polys/ext_fields/transext.cc (modified) (1 diff)

libpolys/polys/ext_fields/transext.cc

@@ -953 +953 @@
      registered cf and perform reference counting rather than creating
      multiple copies of the same coefficient field/domain/ring */
-  return (ntRing == e->r);
+  if (ntRing == e->r)
+    return TRUE;
+
+  // NOTE: Q(a)[x] && Q(a)[y] should better share the _same_ Q(a)...
+  if( rEqual(ntRing, e->r, TRUE) )
+  {
+    rDelete(e->r);
+    return TRUE;
+  }
+
+  return FALSE;  
 }