Changeset 57cf65 in git for libpolys

Timestamp:

Sep 1, 2022, 11:07:39 AM (20 months ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

61b23dbd8490ceddb7e3db6a82bba09eff76d347

Parents:

5b287ee438f34cf6b39493fb6369819bfebc9630

Message:

opt: ksCheckCoeff

Location:

libpolys/polys

Files:

• kbuckets.cc (modified) (3 diffs)
• kbuckets.h (modified) (1 diff)

libpolys/polys/kbuckets.cc

@@ -1428 +1428 @@
 *   reduce is set inside "NF" -> a should be 1
 */
-int ksCheckCoeff(number *a, number *b, const coeffs r, BOOLEAN reduce)
+int ksCheckCoeff(number *a, number *b, const coeffs r, const BOOLEAN reduce)
 {
   int c = 0;
@@ -1435 +1435 @@
   n_Test(bn,r);
 
-  number cn;
-
-  if (n_Equal(an,bn,r))
-  {
-    *a=n_Init(1,r); // gcd is u*a and a/a is 1 (u a unit)
-    *b=n_Init(1,r); // gcd is u*b and b/b is 1 (u a unit)
-    return 3;
-  }
-  else if(reduce) // especially: a|b
+  if(reduce) // especially: a|b
   {
     an = n_Init(1,r); // gcd is u*a, a/a is 1
@@ -1450 +1442 @@
   else
   {
-    cn = n_SubringGcd(an, bn, r);
+    number cn = n_SubringGcd(an, bn, r);
     if(n_IsOne(cn, r))
     {

libpolys/polys/kbuckets.h

@@ -244 +244 @@
 void kBucketSimpleContent(kBucket_pt bucket);
 BOOLEAN kBucketIsCleared(kBucket_pt bucket);
-int ksCheckCoeff(number *a, number *b, const coeffs r, BOOLEAN reduce=FALSE);
+int ksCheckCoeff(number *a, number *b, const coeffs r, const BOOLEAN reduce=FALSE);
 #endif /* KBUCKETS_H */