Changeset 5a0d2ae in git for libpolys

Timestamp:

Nov 24, 2017, 4:09:22 PM (6 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'fieker-DuVal', '117eb8c30fc9e991c4decca4832b1d19036c4c65')(u'spielwiese', '38dfc5131670d387a89455159ed1e071997eec94')

Children:

c11414077180169b27d270988b9dff8a64addaba

Parents:

4b73d0a16e225730f3a8270b63d10086d4d8560a

Message:

chg: prefer mpz_*set_ui over mpz_*set_si for 0/1

Location:

libpolys/coeffs

Files:

• longrat.cc (modified) (1 diff)
• rintegers.cc (modified) (2 diffs)
• rmodulon.cc (modified) (4 diffs)

libpolys/coeffs/longrat.cc

@@ -2816 +2816 @@
   assume(!mpz_isNeg(P));
   if (mpz_isNeg(N))  mpz_add(N,N,P);
-  mpz_init2(A,bits); mpz_set_si(A,0L);
-  mpz_init2(B,bits); mpz_set_si(B,1L);
-  mpz_init2(C,bits); mpz_set_si(C,0L);
+  mpz_init2(A,bits); mpz_set_ui(A,0L);
+  mpz_init2(B,bits); mpz_set_ui(B,1L);
+  mpz_init2(C,bits); mpz_set_ui(C,0L);
   mpz_init2(D,bits);
   mpz_init2(E,bits); mpz_set(E,P);

libpolys/coeffs/rintegers.cc

@@ -410 +410 @@
   if (*s<'0' || *s>'9')
   {
-    mpz_set_si(i,1);
+    mpz_set_ui(i,1);
     return s;
   }
@@ -1697 +1697 @@
   if (*s<'0' || *s>'9')
   {
-    mpz_set_si(i,1);
+    mpz_set_ui(i,1);
     return s;
   }

libpolys/coeffs/rmodulon.cc

@@ -498 +498 @@
   mpz_gcd(tmp, (mpz_ptr) k, r->modNumber);
   if (mpz_cmp_si(tmp, 1)==0) {
-    mpz_set_si(tmp, 0);
+    mpz_set_ui(tmp, 0);
     return (number) tmp;
   }
@@ -584 +584 @@
   mpz_ptr rr = (mpz_ptr)omAllocBin(gmp_nrz_bin);
   mpz_init(g);
-  mpz_init_set_si(rr, 0);
+  mpz_init_set_ui(rr, 0);
   mpz_gcd(g, (mpz_ptr)r->modNumber, (mpz_ptr)b); // g is now as above
   if (mpz_cmp_si(g, 1L) != 0) mpz_mod(rr, (mpz_ptr)a, g); // the case g <> 1
@@ -786 +786 @@
       if (mpz_divisible_p(nrnMapModul, dst->modNumber))
       {
-        mpz_set_si(nrnMapCoef, 1);
+        mpz_set_ui(nrnMapCoef, 1);
       }
       else
@@ -870 +870 @@
   if (!(*s >= '0' && *s <= '9'))
   {
-    mpz_init_set_si(i, 1);
+    mpz_init_set_ui(i, 1);
     return s;
   }