Changeset 5b3fec in git

Timestamp:

Feb 1, 2019, 4:58:13 PM (4 years ago)

Author:

Karim Abou Zeid <karim23697@…>

Branches:

(u'spielwiese', '828514cf6e480e4bafc26df99217bf2a1ed1ef45')

Children:

1e6885f5cacbce6fbbc201cf3104ccc6af24824c

Parents:

37cbc29f515f886b5506d4f7b5731a488acfe576

git-author:

Karim Abou Zeid <karim23697@gmail.com>2019-02-01 16:58:13+01:00

git-committer:

Karim Abou Zeid <karim23697@gmail.com>2019-02-08 17:55:47+01:00

Message:

Add rightstd(), and make std(), rightstd() and reduce() compatible with
qring.

Files:

• Singular/dyn_modules/freegb/freegb.cc (modified) (5 diffs)
• kernel/GBEngine/kstd1.cc (modified) (1 diff)
• kernel/GBEngine/kstd2.cc (modified) (1 diff)
• kernel/GBEngine/kutil.h (modified) (1 diff)

Singular/dyn_modules/freegb/freegb.cc

@@ -2 +2 @@
 
 #ifdef HAVE_SHIFTBBA
-static BOOLEAN freegb(leftv res, leftv args)
+static BOOLEAN freegb(leftv res, leftv args) // freeAlgebra
 {
   const short t1[]={2,RING_CMD,INT_CMD};
@@ -80 +80 @@
 }
 
-/*==================== divide-test for freeGB  =================*/
 static BOOLEAN lpLmDivides(leftv res, leftv h)
 {
@@ -112 +111 @@
 }
 
-/*==================== get var for freeGB  ====================*/
 static BOOLEAN lpVarAt(leftv res, leftv h)
 {
@@ -126 +124 @@
   else return TRUE;
 }
+
+static BOOLEAN rightStd(leftv res, leftv h)
+{
+  const short t[]={1,IDEAL_CMD};
+  if (iiCheckTypes(h,t,1))
+  {
+    ideal id=(ideal)h->Data();
+    res->rtyp = IDEAL_CMD;
+    res->data = rightgb(id, currRing->qideal);
+    return FALSE;
+  }
+  return TRUE;
+}
 #endif
 
@@ -138 +149 @@
   p->iiAddCproc("freegb.so","stest",TRUE,stest);
   p->iiAddCproc("freegb.so","btest",TRUE,btest);
+  p->iiAddCproc("freegb.so","rightstd",FALSE,rightStd);
 #endif
   return (MAX_TOK);

kernel/GBEngine/kstd1.cc

@@ -2093 +2093 @@
 
 #ifdef HAVE_SHIFTBBA
-  if(rIsLPRing(currRing)) return freegb(F);
+  if(rIsLPRing(currRing)) return freegb(F, Q);
 #endif
 

kernel/GBEngine/kstd2.cc

@@ -4459 +4459 @@
 
 
-ideal freegb(ideal F)
+ideal freegb(ideal F, ideal Q)
 {
   assume(rIsLPRing(currRing));
   assume(idIsInV(F));
-  ideal RS = kStdShift(F, NULL, testHomog, NULL);
+  ideal RS = kStdShift(F, Q, testHomog, NULL);
   idSkipZeroes(RS); // is this even necessary?
   assume(idIsInV(RS));

kernel/GBEngine/kutil.h

@@ -861 +861 @@
 int redFirstShift (LObject* h,kStrategy strat); // ok
 
-ideal freegb(ideal F);
+ideal freegb(ideal F, ideal Q);
 ideal rightgb(ideal F, ideal Q);