Changeset 5cecde in git for dyn_modules/syzextra/syzextra.cc

Timestamp:

Aug 2, 2012, 9:58:56 PM (11 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'c987db42cd2ec943b97ac5746c99892ceddf909c')

Children:

e98c64edd3cf15f4e5d15991052a7bbcbb1184a5

Parents:

495328d14a955b215ad10b598e995ab522243881

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-08-02 21:58:56+02:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2014-05-07 04:41:46+02:00

Message:

Totally bitmasked: CReducerFinder: FindReducer uses syz_checker.IsDivisible()

File:

• dyn_modules/syzextra/syzextra.cc (modified) (12 diffs)

dyn_modules/syzextra/syzextra.cc

@@ -511 +511 @@
   assume( IDELEMS(L) == IDELEMS(T) );
 
-  ComputeLeadingSyzygyTerms( __LEAD2SYZ__ ); // 2 terms OR 1 term!
+  if( m_syzLeads == NULL )
+    ComputeLeadingSyzygyTerms( __LEAD2SYZ__ ); // 2 terms OR 1 term!
+
+  assume( m_syzLeads != NULL );
+
+  if( __TAILREDSYZ__ )
+    assume( m_checker.IsNonempty() );
 
   ideal& LL = m_syzLeads;
+
   
   const int size = IDELEMS(LL);
@@ -564 +571 @@
       if( a2 == NULL )
       {
-        aa = p_Mult_mm(aa, L->m[r], R); a2 = m_div.FindReducer(aa, a); 
+        aa = p_Mult_mm(aa, L->m[r], R); a2 = m_div.FindReducer(aa, a, m_checker); 
       }
       assume( a2 != NULL );
@@ -600 +607 @@
   
   // NOTE: set m_LS if tails are to be reduced!
-
-  if (__TAILREDSYZ__)
+  assume( m_syzLeads!= NULL );
+
+  if (__TAILREDSYZ__ && (IDELEMS(m_syzLeads) > 0))
+  {
     m_LS = m_syzLeads;
+    m_checker.Initialize(m_syzLeads);
+  }
 
   (void)( __LEAD2SYZ__ );
@@ -618 +629 @@
   const ideal& L = m_idLeads;
   const ideal& T = m_idTails;
-//  const ideal& LS = m_LS;
   const ring& r = m_rBaseRing;
 
@@ -656 +666 @@
   while (spoly != NULL)
   {
-    poly t = m_div.FindReducer(spoly, NULL);
+    poly t = m_div.FindReducer(spoly, NULL, m_checker);
 
     p_LmDelete(&spoly, r);
@@ -756 +766 @@
     // NOTE: only LT(term4reduction) should be used in the following:
     poly product = pp_Mult_mm(multiplier, term4reduction, r);
-    s = m_div.FindReducer(product, syztermCheck);
+    s = m_div.FindReducer(product, syztermCheck, m_checker);
     p_Delete(&product, r);
   }
@@ -834 +844 @@
 }
 
-CReducerFinder::CReducerFinder(const SchreyerSyzygyComputation& data):
-    SchreyerSyzygyComputationFlags(data), 
-    m_data(data),
+
+void CReducerFinder::Initialize(const ideal L)
+{
+  assume( m_L == NULL || m_L == L );
+  if( m_L == NULL )
+    m_L = L;
+
+  assume( m_L == L );
+  
+  if( L != NULL )
+  {
+    const ring& R = m_rBaseRing;
+    assume( R != NULL );
+    
+    for( int k = IDELEMS(L) - 1; k >= 0; k-- )
+    {
+      const poly a = L->m[k]; // assume( a != NULL );
+
+      // NOTE: label is k \in 0 ... |L|-1!!!
+      if( a != NULL )
+        m_hash[p_GetComp(a, R)].push_back( new CLeadingTerm(k, a, R) );
+    }
+  }
+}
+
+CReducerFinder::CReducerFinder(const ideal L, const SchreyerSyzygyComputationFlags& flags):
+    SchreyerSyzygyComputationFlags(flags),
+    m_L(const_cast<ideal>(L)), // for debug anyway
     m_hash()
 {
-  const ring&  R = m_rBaseRing;
-  assume( data.m_rBaseRing == R );
-  assume( R != NULL );
-//   const SchreyerSyzygyComputationFlags& attributes = data.m_atttributes;
-// 
-//   const BOOLEAN __DEBUG__      = attributes.__DEBUG__;
-//   const BOOLEAN __SYZCHECK__   = attributes.__SYZCHECK__;
-//   const BOOLEAN __HYBRIDNF__   = attributes.__HYBRIDNF__;
-//   const BOOLEAN __TAILREDSYZ__ = attributes.__TAILREDSYZ__;
-
-
-  const ideal& L = data.m_idLeads; assume( L != NULL );
-
-  for( int k = IDELEMS(L) - 1; k >= 0; k-- )
-  {
-    const poly a = L->m[k]; assume( a != NULL );
-
-    // NOTE: label is k \in 0 ... |L|-1!!!
-    m_hash[p_GetComp(a, R)].push_back( new CLeadingTerm(k, a, R) );
-  }
-}
-
-
-poly CReducerFinder::FindReducer(const poly product, const poly syzterm) const
-{
-//  return FROM_NAMESPACE(INTERNAL, _FindReducer(product, syzterm, m_idLeads, m_LS, m_rBaseRing, m_atttributes));
-//  poly _FindReducer(poly product, poly syzterm,
-//                     ideal L, ideal LS,
-//                     const ring r,
-//                     const SchreyerSyzygyComputationFlags attributes)
-
-  const ideal& L = m_data.m_idLeads;
-  const ideal& LS = m_data.m_LS;
+  assume( flags.m_rBaseRing == m_rBaseRing );
+  if( L != NULL )
+    Initialize(L);
+}
+
+
+bool CReducerFinder::IsDivisible(const poly product) const
+{
   const ring& r = m_rBaseRing;
-//  const SchreyerSyzygyComputationFlags& attributes = m_data.m_atttributes;
-
-
-//  const BOOLEAN __DEBUG__      = m_data.__DEBUG__;
-//  const BOOLEAN __SYZCHECK__   = m_data.__SYZCHECK__;
-//   const BOOLEAN __LEAD2SYZ__   = attributes.__LEAD2SYZ__;
-//   const BOOLEAN __HYBRIDNF__   = attributes.__HYBRIDNF__;
-//  const BOOLEAN __TAILREDSYZ__ = m_data.__TAILREDSYZ__;
+  
+  const long comp = p_GetComp(product, r);
+  const unsigned long not_sev = ~p_GetShortExpVector(product, r);
+
+  assume( comp >= 0 );
+
+  CReducersHash::const_iterator it = m_hash.find(comp); // same module component
+
+  if( it == m_hash.end() )
+    return false;
+
+  assume( m_L != NULL );  
+
+  const TReducers& reducers = it->second;
+
+  for(TReducers::const_iterator vit = reducers.begin(); vit != reducers.end(); vit++ )
+  {
+    const poly p = (*vit)->m_lt;
+
+    assume( p_GetComp(p, r) == comp );
+
+    const int k = (*vit)->m_label;
+
+    assume( m_L->m[k] == p );
+
+    const unsigned long p_sev = (*vit)->m_sev;
+
+    assume( p_sev == p_GetShortExpVector(p, r) );     
+
+    if( !p_LmShortDivisibleByNoComp(p, p_sev, product, not_sev, r) )
+      continue;
+
+    if( __DEBUG__ )
+    {
+      Print("_FindReducer::Test LS: q is divisible by LS[%d] !:((, diviser is: ", k+1);
+      dPrint(p, r, r, 1);
+    }
+
+    return true;
+  }
+
+  return false;
+}
+
+
+poly CReducerFinder::FindReducer(const poly product, const poly syzterm, const CReducerFinder& syz_checker) const
+{
+  const ring& r = m_rBaseRing;
 
   assume( product != NULL );
-  assume( L != NULL );
+
+  const ideal& L = m_L; assume( L != NULL ); // for debug/testing only!
 
   long c = 0;
@@ -912 +963 @@
   assume( comp >= 0 );
 
+//   for( int k = IDELEMS(L)-1; k>= 0; k-- )
+//   {
+//     const poly p = L->m[k];
+// 
+//     if ( p_GetComp(p, r) != comp )
+//       continue;
+// 
+//     const unsigned long p_sev = p_GetShortExpVector(p, r); // to be stored in m_hash!!!
+  
    // looking for an appropriate diviser p = L[k]...
-#if 1
-  CReducersHash::const_iterator it = m_hash.find(p_GetComp(product, r)); // same module component
+  CReducersHash::const_iterator it = m_hash.find(comp); // same module component
 
   if( it == m_hash.end() )
     return NULL;
 
-  const TReducers& reducers = it->second;  
-
+  assume( m_L != NULL );
+
+  const TReducers& reducers = it->second;
+
+  const BOOLEAN to_check = __TAILREDSYZ__ && (syz_checker.IsNonempty());
+
+  const poly q = p_New(r); pNext(q) = NULL;
+
+  if( __DEBUG__ )
+    p_SetCoeff0(q, 0, r); // for printing q
+  
   for(TReducers::const_iterator vit = reducers.begin(); vit != reducers.end(); vit++ )
   {
@@ -934 +1002 @@
 
     assume( p_sev == p_GetShortExpVector(p, r) );     
-#else  
-  for( int k = IDELEMS(L)-1; k>= 0; k-- )
-  {
-    const poly p = L->m[k];
-
-    if ( p_GetComp(p, r) != comp )
-      continue;
-
-    const unsigned long p_sev = p_GetShortExpVector(p, r); // to be stored in m_hash!!!
-#endif
 
     if( !p_LmShortDivisibleByNoComp(p, p_sev, product, not_sev, r) )
@@ -952 +1010 @@
 //       continue;
 
-
-    const poly q = p_New(r);
-    pNext(q) = NULL;
     p_ExpVectorDiff(q, product, p, r); // (LM(product) / LM(L[k]))
     p_SetComp(q, k + 1, r);
@@ -969 +1024 @@
         }    
 
-        p_LmFree(q, r);
         continue;
       }
 
     // while the complement (the fraction) is not reducible by leading syzygies 
-    if( LS != NULL )
+    if( to_check && syz_checker.IsDivisible(q) ) 
     {
-      assume( __TAILREDSYZ__ );
-      BOOLEAN ok = TRUE;
-
-      // TODO: FindReducer in LS !!! there should be no divisors!
-      for(int kk = IDELEMS(LS)-1; kk>= 0; kk-- )
+      if( __DEBUG__ )
       {
-        const poly pp = LS->m[kk];
-
-        if( p_LmDivisibleBy(pp, q, r) )
-        {
-
-          if( __DEBUG__ )
-          {
-            Print("_FindReducer::Test LS: q is divisible by LS[%d] !:((, diviser is: ", kk+1);
-            dPrint(pp, r, r, 1);
-          }    
-
-          ok = FALSE; // q in <LS> :((
-          break;                 
-        }
+        PrintS("_FindReducer::Test LS: q is divisible by LS[?] !:((: ");
       }
-
-      if(!ok)
-      {
-        p_LmFree(q, r);
-        continue;
-      }
+      
+      continue;
     }
 
     p_SetCoeff0(q, n_Neg( n_Div( p_GetCoeff(product, r), p_GetCoeff(p, r), r), r), r);
     return q;
-
-  }
-
+  }
+
+  p_LmFree(q, r);
 
   return NULL;
@@ -1016 +1049 @@
 
 
-  CLCM::CLCM(const SchreyerSyzygyComputation& data):
-      SchreyerSyzygyComputationFlags(data), std::vector<bool>(), m_data(data), m_compute(false)
-  {
-
-    const ring&  R = m_rBaseRing;
-    assume( data.m_rBaseRing == R );
-    assume( R != NULL );
-//  const SchreyerSyzygyComputationFlags& attributes = data.m_atttributes;
-
-//  const BOOLEAN __DEBUG__      = attributes.__DEBUG__;
-//  const BOOLEAN __SYZCHECK__   = attributes.__SYZCHECK__;
-//    const BOOLEAN __HYBRIDNF__   = m_data.__HYBRIDNF__;
-//    const BOOLEAN __TAILREDSYZ__ = m_data.__TAILREDSYZ__;
-
-
-    const ideal& L = data.m_idLeads;
-    assume( L != NULL );
-
-    if( __TAILREDSYZ__ && !__HYBRIDNF__ )
+CLCM::CLCM(const ideal& L, const SchreyerSyzygyComputationFlags& flags):
+    SchreyerSyzygyComputationFlags(flags), std::vector<bool>(),
+    m_compute(false), m_N(rVar(flags.m_rBaseRing))
+{
+  const ring& R = m_rBaseRing;
+  assume( flags.m_rBaseRing == R );
+  assume( R != NULL );
+
+  assume( L != NULL );
+
+  if( __TAILREDSYZ__ && !__HYBRIDNF__ && (L != NULL))
+  {
+    const int l = IDELEMS(L);
+
+    assume( l > 0 );
+
+    resize(l, false);
+
+    for( int k = l - 1; k >= 0; k-- )
     {
-      const int l = IDELEMS(L);
-
-      resize(l, false);
-
-      const unsigned int N = rVar(R);
-
-      for( int k = l - 1; k >= 0; k-- )
-      {
-        const poly a = L->m[k]; assume( a != NULL );
-
-        for (unsigned int j = N; j > 0; j--)
-          if ( !(*this)[j] )
-            (*this)[j] = (p_GetExp(a, j, R) > 0);
-      }
-
-      m_compute = true;    
+      const poly a = L->m[k]; assume( a != NULL );
+
+      for (unsigned int j = m_N; j > 0; j--)
+        if ( !(*this)[j] )
+          (*this)[j] = (p_GetExp(a, j, R) > 0);
     }
-  }
-
-
-  bool CLCM::Check(const poly m) const
-  {
-    assume( m != NULL );
-    if( m_compute && (m != NULL))
-    {  
-      const ring& R = m_data.m_rBaseRing;
-//    const SchreyerSyzygyComputationFlags& attributes = m_data.m_atttributes;
-
-  //  const BOOLEAN __DEBUG__      = attributes.__DEBUG__;
-  //  const BOOLEAN __SYZCHECK__   = attributes.__SYZCHECK__;
-//      const BOOLEAN __HYBRIDNF__   = m_data.__HYBRIDNF__;
-//      const BOOLEAN __TAILREDSYZ__ = m_data.__TAILREDSYZ__;
-
-      assume( R != NULL );
-      assume( R == currRing ); 
-
-      assume( __TAILREDSYZ__ && !__HYBRIDNF__ );
-
-      const unsigned int N = rVar(R);
-
-      for (unsigned int j = N; j > 0; j--)
-        if ( (*this)[j] )
-          if(p_GetExp(m, j, R) > 0)
-            return true;
-
-      return false;
-
-    } else return true;
-  }
+
+    m_compute = true;    
+  }
+}
+
+
+bool CLCM::Check(const poly m) const
+{
+  assume( m != NULL );
+  if( m_compute && (m != NULL))
+  {  
+    const ring& R = m_rBaseRing;
+
+    assume( __TAILREDSYZ__ && !__HYBRIDNF__ );
+
+    for (unsigned int j = m_N; j > 0; j--)
+      if ( (*this)[j] )
+        if(p_GetExp(m, j, R) > 0)
+          return true;
+
+    return false;
+
+  } else return true;
+}