Changeset 5d18675 in git for libpolys

Timestamp:

Sep 29, 2011, 2:04:24 AM (13 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

0ff2030fd072d70a06a89af842c039505b704f90

Parents:

b38d70eb347f3022d2862a75897727cb85659cfe

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2011-09-29 02:04:24+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 16:13:47+01:00

Message:

FIX: rDecompose should know about trans. exts.

File:

• libpolys/polys/monomials/ring.h (modified) (3 diffs)

libpolys/polys/monomials/ring.h

@@ -482 +482 @@
 { assume(r != NULL); assume(r->cf != NULL); return nCoeff_has_simple_inverse(r->cf); }
 
+/// Z/p, GF(p,n), R: nCopy, nNew, nDelete are dummies
 static inline BOOLEAN rField_has_simple_Alloc(const ring r)
 { assume(r != NULL); assume(r->cf != NULL); return nCoeff_has_simple_Alloc(r->cf); }
 
-/* Z/p, GF(p,n), R: nCopy, nNew, nDelete are dummies*/
+/// Alg. or trans. ext. 
 static inline BOOLEAN rField_is_Extension(const ring r)
 { assume(r != NULL); assume(r->cf != NULL); return nCoeff_is_Extension(r->cf); } /* Z/p(a) and Q(a)*/
@@ -547 +548 @@
   assume(C != NULL);
 
-  if( rField_is_Extension(r) )
+  if( rField_is_Extension(r) ) // only alg / trans. exts...
   {
     const ring R = C->extRing;
@@ -577 +578 @@
 static inline BOOLEAN rIsExtension(const ring r)
 {
-  assume( (rParameter(r)!=NULL) == rField_is_Extension(r) ); // ?
-  return rField_is_Extension(r);
+//  assume( (rParameter(r)!=NULL) == rField_is_Extension(r) ); // ?
+  return rField_is_Extension(r) || nCoeff_is_GF(r->cf) ;
 }