Changeset 6da2d6 in git for omalloc

Timestamp:

Nov 12, 2015, 3:45:23 PM (8 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '17f1d200f27c5bd38f5dfc6e8a0879242279d1d8')

Children:

9eb1e8694ce6e4868f9d9677e607c646e3bb2d96

Parents:

2bf04b125a602824542ca32e0d085ec5fdbaf789

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2015-11-12 15:45:23+01:00

git-committer:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2015-11-12 15:48:44+01:00

Message:

omalloc: disable debug stuff unless configured with --enable-debug

remove --with-debug (being consistent with the main configure)

From info file of GCC/ C Extensions

On some machines it may be impossible to determine the return address of any function other than the current one; in such cases, or when the top of the stack has been reached, this function returns 0 or a random value. In addition, __builtin_frame_address may be used to determine if the top of the stack has been reached.

Calling this function with a nonzero argument can have unpredictable effects, including crashing the calling program. As a result, calls that are considered unsafe are diagnosed when the -Wframe-address option is in effect. Such calls should only be made in debugging situations.

File:

• omalloc/configure.ac (modified) (5 diffs)

omalloc/configure.ac

@@ -72 +72 @@
   [ --without-inline   do not inline])
 AC_ARG_WITH(
-  debug,
-  [ --without-debug    disable all debugging facilities])
-AC_ARG_WITH(
   track,
   [ --without-track    disable debug tracking functionality])
@@ -93 +90 @@
   [ --with-internal-debug
                        turn on internal debugging])
+AC_ARG_ENABLE(
+  debug,
+  [ --enable-debug    include backtrace stuff])
 dnl lllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllll
 dnl compiler/make  config
@@ -415 +415 @@
 save_cflags="$CFLAGS"
 AC_MSG_CHECKING(whether to disable debugging)
-if test "$with_debug" != no; then
+if test "$enable_debug" = yes; then
 AC_MSG_RESULT(no)
 CFLAGS="$CFLAGS -g"
@@ -459 +459 @@
 dnl backtrace business
 dnl
+if test "x$with_track" != xno; then
 AC_MSG_CHECKING(whether GET_RET_ADDR works)
 AC_CACHE_VAL(ac_cv_get_return_addr_works,
@@ -515 +516 @@
 if test "$ac_cv_get_backtrace_works" = yes; then
 AC_DEFINE(OM_GET_BACKTRACE_WORKS,1,"Whether omInitGetBackTrace () works")
+fi
+else
+   AC_MSG_CHECKING(whether GET_RET_ADDR works)
+   ac_cv_get_return_addr_works=no
+   AC_MSG_RESULT($ac_cv_get_return_addr_works)
+   AC_MSG_CHECKING(whether omGetBackTrace works)
+   ac_cv_get_backtrace_works=no
+   AC_MSG_RESULT($ac_cv_get_backtrace_works)
 fi