Changeset 70b3ae in git for Singular/ipshell.cc

Timestamp:

Nov 8, 2013, 5:22:35 PM (9 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'f875bbaccd0831e36aaed09ff6adeb3eb45aeb94')

Children:

85d15b1ccdb95aa5a0dab7c7a66ad09cfd7631ed

Parents:

abb12f44bb1ce32fc8fa27a5f627543824466fce

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2013-11-08 17:22:35+01:00

git-committer:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2013-11-08 17:41:31+01:00

Message:

fix: ring constructions with wrong coeffs (tr.517)

File:

• Singular/ipshell.cc (modified) (3 diffs)

Singular/ipshell.cc

@@ -5069 +5069 @@
       if (ch!=0)
       {
-        if (ch<2)
+        int ch2=IsPrime(ch);
+        if ((ch<2)||(ch!=ch2))
         {
-          Warn("%d is invalid characteristic of ground field. 32003 is used.", ch);
+          Warn("%d is invalid as characteristic of the ground field. 32003 is used.", ch);
           ch=32003;
         }
-        ch=IsPrime(ch);
         cf = nInitChar(n_Zp, (void*)(long)ch);
       }
@@ -5230 +5230 @@
       else
       {
+        if (mpz_cmp_ui(modBase,0)==0)
+        {
+          WerrorS("modulus must not be 0");
+          goto rInitError;
+        }
         //ringtype = 3;
         ZnmInfo info;
@@ -5240 +5245 @@
     else if (cf == NULL)
     {
+      if (mpz_cmp_ui(modBase,0)==0)
+      {
+        WerrorS("modulus must not be 0");
+        goto rInitError;
+      }
       //ringtype = 2;
       ZnmInfo info;