Changeset 73a9ffb in git for libpolys/coeffs/coeffs.h

Timestamp:

May 26, 2011, 10:29:03 AM (12 years ago)

Author:

Frank Seelisch <seelisch@…>

Branches:

(u'spielwiese', '8e0ad00ce244dfd0756200662572aef8402f13d5')

Children:

488808e90a9444d2ce5d16be059643fdd2e8629e

Parents:

e676cdf123bc41ae953d7fd58106263f5fd02d0c

git-author:

Frank Seelisch <seelisch@mathematik.uni-kl.de>2011-05-26 10:29:03+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 12:36:53+01:00

Message:

made sure that ch is properly set everywhere, and ch >= 0; more ASSUMEs

File:

• libpolys/coeffs/coeffs.h (modified) (3 diffs)

libpolys/coeffs/coeffs.h

@@ -217 +217 @@
   unsigned long mod2mMask;
 #endif
-  int        ch;  /* characteristic, rInit
-                     PLEASE DOCUMENT HERE when this will be negative! */
+  int        ch;  /* characteristic, set by the local *InitChar methods;
+                     In field extensions or extensions towers, the
+                     characteristic can be accessed from any of the
+                     intermediate extension fields, i.e., in this case
+                     it is redundant along the chain of field extensions;
+                     CONTRARY to SINGULAR as it was, we do NOT LONGER use
+                     negative values for ch. */
 
   short      float_len; /* additional char-flags, rInit */
@@ -459 +464 @@
   return (r->ringtype == 0) &&
          ((getCoeffType(r)==n_algExt) || (getCoeffType(r)==n_transExt)) &&
-         (r->ch < -1);
+         (r->ch != 0);
 }
 
@@ -469 +474 @@
   return (r->ringtype == 0) &&
          ((getCoeffType(r)==n_algExt) || (getCoeffType(r)==n_transExt)) &&
-         (r->ch < -1 ) && (-(r->ch) == p);
+         (r->ch != 0) && (r->ch == p);
 }