Changeset 73a9ffb in git for libpolys/polys/ext_fields/algext.cc

Timestamp:

May 26, 2011, 10:29:03 AM (12 years ago)

Author:

Frank Seelisch <seelisch@…>

Branches:

(u'spielwiese', '8e0ad00ce244dfd0756200662572aef8402f13d5')

Children:

488808e90a9444d2ce5d16be059643fdd2e8629e

Parents:

e676cdf123bc41ae953d7fd58106263f5fd02d0c

git-author:

Frank Seelisch <seelisch@mathematik.uni-kl.de>2011-05-26 10:29:03+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 12:36:53+01:00

Message:

made sure that ch is properly set everywhere, and ch >= 0; more ASSUMEs

File:

• libpolys/polys/ext_fields/algext.cc (modified) (3 diffs)

libpolys/polys/ext_fields/algext.cc

@@ -37 +37 @@
 
 #include <polys/ext_fields/algext.h>
+
+/// our type has been defined as a macro in algext.h
+/// and is accessible by 'naID'
 
 /// forward declarations
@@ -569 +572 @@
 BOOLEAN naInitChar(coeffs cf, void * infoStruct)
 {
+  assume( getCoeffType(cf) == naID );
+  
   ExtInfo *e = (ExtInfo *)infoStruct;
   /// first check whether cf->algring != NULL and delete old ring???
@@ -581 +586 @@
   assume(getCoeffType(cf) == naID);                     // coeff type;
   
-  cf->ch = -cf->algring->cf->ch;   /* propagate characteristic up so that it
-                                      becomes directly accessible in cf;
-                                      negative sign to signal that it's an
-                                      extension field */
+  /* propagate characteristic up so that it becomes
+     directly accessible in cf: */
+  cf->ch = cf->algring->cf->ch;
   
   #ifdef LDEBUG