Changeset 79020f in git for libpolys/polys

Timestamp:

Jan 6, 2012, 9:28:16 PM (12 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

40e88db63c509564c2b00b7142b39ef6b846f72e

Parents:

1cbb1f452324cf72b33ef5a1cb6256d97bcbcbd0

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-01-06 21:28:16+01:00

git-committer:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2012-01-06 21:59:37+01:00

Message:

fixed arithmetic overflow by rewriting nlModP

CHG: nlModP (longrat) was rewritten in order to simplify and generalize it
CHG/FIX: nlModP _works_ again as in the old Singular (uses n_Div)

Location:

libpolys/polys/ext_fields

Files:

• algext.cc (modified) (1 diff)
• transext.cc (modified) (2 diffs)

libpolys/polys/ext_fields/algext.cc

@@ -650 +650 @@
   if (n_IsZero(a, src)) return NULL;
   int p = rChar(dst->extRing);
-  int n = nlModP(a, p, src);
-  number q = n_Init(n, dst->extRing->cf);
-  poly result = p_One(dst->extRing);
-  p_SetCoeff(result, q, dst->extRing);
+
+  number q = nlModP(a, src, dst->extRing->cf);
+
+  poly result = p_NSet(q, dst->extRing);
+  
   return (number)result;
 }

libpolys/polys/ext_fields/transext.cc

@@ -1119 +1119 @@
   if (n_IsZero(a, src)) return NULL;
   int p = rChar(dst->extRing);
-  int n = nlModP(a, p, src);
-  number q = n_Init(n, dst->extRing->cf);
-  poly g;
+  number q = nlModP(a, src, dst->extRing->cf);
+
   if (n_IsZero(q, dst->extRing->cf))
   {
@@ -1127 +1126 @@
     return NULL;
   }
-  g = p_One(dst->extRing);
-  p_SetCoeff(g, q, dst->extRing);
+  
+  poly g = p_NSet(q, dst->extRing);
+
   fraction f = (fraction)omAlloc0Bin(fractionObjectBin);
   NUM(f) = g; // DEN(f) = NULL; COM(f) = 0;