Changeset 7dce2d7 in git

Timestamp:

Apr 20, 2011, 5:24:15 PM (12 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', '0604212ebb110535022efecad887940825b97c3f')

Children:

9765f3b4f33f8fae7a5ca4ed7831d01d8ca37a06

Parents:

7f602bf34cba1848ae22dbe21a65ea4f2460604f

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2011-04-20 17:24:15+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 12:31:21+01:00

Message:

add comments to some coeff functions
add p_EqualPolys
fix warnings in mod_raw.cc

Location:

libpolys

Files:

• coeffs/coeffs.h (modified) (2 diffs)
• polys/monomials/p_polys.cc (modified) (1 diff)
• polys/templates/mod_raw.cc (modified) (2 diffs)

libpolys/coeffs/coeffs.h

@@ -378 +378 @@
 { return (r->ringtype != 0); }
 
+/// returns TRUE, if r is not a field and r has no zero divisors (i.e is a domain)
 static inline BOOLEAN nCoeff_is_Domain(const coeffs r)
 { return (r->ringtype == 4 || r->ringtype == 0); }
 
+/// returns TRUE, if r is not a field and r has non-trivial units
 static inline BOOLEAN nCoeff_has_Units(const coeffs r)
 { return ((r->ringtype == 1) || (r->ringtype == 2) || (r->ringtype == 3)); }
@@ -423 +425 @@
 { return getCoeffType(r)==n_CF; }
 
+/// TRUE, if the computation of the inverse is fast (i.e. prefer leading coeff. 1 over content)
 static inline BOOLEAN nCoeff_has_simple_inverse(const coeffs r)
 { return r->has_simple_Inverse; }
 /* Z/2^n, Z/p, GF(p,n), R, long_R, long_C*/
 
+/// TRUE if n_Delete/n_New are empty operations
 static inline BOOLEAN nCoeff_has_simple_Alloc(const coeffs r)
 { return r->has_simple_Alloc; }

libpolys/polys/monomials/p_polys.cc

@@ -3533 +3533 @@
 }
 
+BOOLEAN p_EqualPolys(poly p1,poly p2, const ring r)
+{
+  while ((p1 != NULL) && (p2 != NULL))
+  {
+    if (! p_LmEqual(p1, p2,r))
+      return FALSE;
+    if (! n_Equal(p_GetCoeff(p1,r), p_GetCoeff(p2,r),r ))
+      return FALSE;
+    pIter(p1);
+    pIter(p2);
+  }
+  return (p1==p2);
+}
 
 /*2

libpolys/polys/templates/mod_raw.cc

@@ -39 +39 @@
 lib_types type_of_LIB(char *newlib, char *libnamebuf)
 {
-  const char mach_o[]={0xfe,0xed,0xfa,0xce,0};
-  const char mach_o_module[]={0xce,0xfa,0xed,0xfe,0};
+  const unsigned char mach_o[]={0xfe,0xed,0xfa,0xce,0};
+  const unsigned char mach_o_module[]={0xce,0xfa,0xed,0xfe,0};
   char        buf[BYTES_TO_CHECK+1];        /* one extra for terminating '\0' */
   struct stat sb;
@@ -77 +77 @@
   }
 
-  if( (strncmp(buf, &mach_o[0], 4)==0)) /* generic Mach-O module */
+  if( (strncmp(buf, (const char *)mach_o, 4)==0)) /* generic Mach-O module */
   {
     LT = LT_MACH_O;