Changeset 8e903f in git for kernel/GBEngine/kspoly.cc

Timestamp:

Apr 24, 2020, 7:01:53 PM (4 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '17f1d200f27c5bd38f5dfc6e8a0879242279d1d8')

Children:

34ac5c4176020d530d61125750c8457430cd7f22

Parents:

b94a72a3900cee27c0409f0d8cfe58d9e880654c756dc7155d3cba64f765acc3475e5c4e12cdbbff

git-author:

Hans Schoenemann <hannes@mathematik.uni-kl.de>2020-04-24 19:01:53+02:00

git-committer:

GitHub <noreply@github.com>2020-04-24 19:01:53+02:00

Message:

Merge pull request #990 from kabouzeid/stable

Fix segfault because of components in LP

File:

• kernel/GBEngine/kspoly.cc (modified) (4 diffs)

kernel/GBEngine/kspoly.cc

@@ -312 +312 @@
 }
 
+#ifdef HAVE_RINGS
 int ksReducePolyGCD(LObject* PR,
                  TObject* PW,
@@ -399 +400 @@
     ct = n_ExtGcd(pGetCoeff(p1), pGetCoeff(p2), &an, &bn, tailRing->cf);    // Calculate GCD
 #ifdef HAVE_SHIFTBBA
-    if (n_IsZero(an, tailRing->cf) || n_IsZero(bn, tailRing->cf))
-    {
-      // NOTE: not sure why this is not checked in the commutative case, this *does* happen and then zero coeff errors are reported
-
-      // NOTE: we are probably leaking memory of lm=pOne(), but we cannot delete it since it could also be lm=p1
-      n_Delete(&an, tailRing->cf);
-      n_Delete(&bn, tailRing->cf);
-      n_Delete(&ct, tailRing->cf);
-      return ret;
+    if(rIsLPRing(tailRing)) /* with this test: error at New/stdZtests.tst, infinite : Long/primdecint.tst */
+    {
+      if (n_IsZero(an, tailRing->cf) || n_IsZero(bn, tailRing->cf))
+      {
+        // NOTE: not sure why this is not checked in the commutative case, this *does* happen and then zero coeff errors are reported
+        // NOTE: we are probably leaking memory of lm=pOne(), but we cannot delete it since it could also be lm=p1
+        n_Delete(&an, tailRing->cf);
+        n_Delete(&bn, tailRing->cf);
+        n_Delete(&ct, tailRing->cf);
+        return ret;
+      }
     }
 #endif
@@ -437 +440 @@
   return ret;
 }
+#endif
 
 /* Computes a reduction of the lead coefficient only. We have already tested
@@ -1413 +1417 @@
 #ifdef HAVE_SHIFTBBA
   int shift1, shift2;
-  if (tailRing->isLPring) {
+  if (tailRing->isLPring)
+  {
     // assume: LM is shifted, tail unshifted
     assume(p_FirstVblock(a1, tailRing) <= 1);