Changeset 8ea64b in git for libpolys

Timestamp:

Apr 22, 2021, 4:03:15 PM (3 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '2a584933abf2a2d3082034c7586d38bb6de1a30a')

Children:

5fd24e69d9cdfcd1040ca93af529563f039efd2c

Parents:

7760bca34e9c98f7c8b022a5aa89971f7d3a4fd7

Message:

fix: ndIsUnit, ndGetUnit

File:

• libpolys/coeffs/numbers.cc (modified) (3 diffs)

libpolys/coeffs/numbers.cc

@@ -119 +119 @@
 }
 
-static BOOLEAN ndIsUnit(number a, const coeffs r) { return !r->cfIsZero(a,r); }
+static BOOLEAN ndIsUnit(number a, const coeffs r)
+{ return r->cfIsOne(a,r)|| r->cfIsMOne(a,r); }
+static number ndGetUnit(number a, const coeffs r)
+{ return r->cfInit(1,r); }
 #ifdef LDEBUG
 // static void   nDBDummy1(number* d,char *, int) { *d=NULL; }
@@ -409 +412 @@
     n->cfDivBy = ndDivBy;
     n->cfExtGcd = ndExtGcd;
-    //n->cfGetUnit = (nMapFunc)NULL;
+    n->cfGetUnit = ndGetUnit;
 #endif
 
@@ -436 +439 @@
     if (n->cfSubringGcd==NULL) n->cfSubringGcd=n->cfGcd;
 
-#ifdef HAVE_RINGS
-    if (n->cfGetUnit==NULL) n->cfGetUnit=n->cfCopy;
-#endif
 
     if(n->cfWriteShort==NULL)