Changeset 935e83 in git for factory

Timestamp:

Feb 2, 2012, 11:38:50 AM (12 years ago)

Author:

Martin Lee <martinlee84@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

3ef2d61ea9f830707a76fcbf852b171be8716d84

Parents:

c53fdcb0540662085a9f0550fb16457042f01035

git-author:

Martin Lee <martinlee84@web.de>2012-02-02 11:38:50+01:00

git-committer:

Martin Lee <martinlee84@web.de>2012-04-04 14:42:25+02:00

Message:

chg: deleted some commented out debug stuff and formatted code

File:

• factory/facHensel.cc (modified) (67 diffs)

factory/facHensel.cc

@@ -52 +52 @@
       convertCF2Fmpz (fmpz_poly_get_coeff_ptr (result, i.exp()*d), i.coeff());
     else
-      for (j=i.coeff(); j.hasTerms(); j++)
-        convertCF2Fmpz (fmpz_poly_get_coeff_ptr (result,i.exp()*d+j.exp()), j.coeff());
+      for (j= i.coeff(); j.hasTerms(); j++)
+        convertCF2Fmpz (fmpz_poly_get_coeff_ptr (result, i.exp()*d+j.exp()),
+                        j.coeff());
   }
   _fmpz_poly_normalise(result);
-
-
-  /*fmpz_t coeff;
-  for (CFIterator i= A; i.hasTerms(); i++)
-  {
-    if (i.coeff().inBaseDomain())
-    {
-      convertCF2Fmpz (coeff, i.coeff());
-      fmpz_poly_set_coeff_fmpz (result, i.exp()*d, coeff);
-    }
-    else
-    {
-      for (CFIterator j= i.coeff();j.hasTerms(); j++)
-      {
-        convertCF2Fmpz (coeff, j.coeff());
-        fmpz_poly_set_coeff_fmpz (result, i.exp()*d+j.exp(), coeff);
-      }
-    }
-  }
-  fmpz_clear (coeff);
-  _fmpz_poly_normalise (result);*/
-}
-
-
-CanonicalForm reverseSubst (const fmpz_poly_t F, int d, const Variable& alpha, const CanonicalForm& den)
+}
+
+
+CanonicalForm
+reverseSubst (const fmpz_poly_t F, int d, const Variable& alpha,
+              const CanonicalForm& den)
 {
   Variable x= Variable (1);
@@ -89 +71 @@
   int k= 0;
   int degfSubK;
-  int repLength;
+  int repLength, j;
   CanonicalForm coeff;
   fmpz* tmp;
@@ -101 +83 @@
       repLength= degfSubK + 1;
 
-    for (int j= 0; j < repLength; j++)
+    for (j= 0; j < repLength; j++)
     {
       tmp= fmpz_poly_get_coeff_ptr (F, j+k);
@@ -117 +99 @@
 }
 
-CanonicalForm mulFLINTQa (const CanonicalForm& F, const CanonicalForm& G, const Variable& alpha)
+CanonicalForm
+mulFLINTQa (const CanonicalForm& F, const CanonicalForm& G,
+            const Variable& alpha)
 {
   CanonicalForm A= F;
@@ -171 +155 @@
 }
 
-CanonicalForm
+/*CanonicalForm
 mulFLINTQ2 (const CanonicalForm& F, const CanonicalForm& G)
 {
@@ -186 +170 @@
   fmpq_poly_clear (FLINTB);
   return A;
-}
+}*/
 
 CanonicalForm
@@ -225 +209 @@
 
 CanonicalForm
-mulFLINTQaTrunc (const CanonicalForm& F, const CanonicalForm& G, const Variable& alpha, int m)
+mulFLINTQaTrunc (const CanonicalForm& F, const CanonicalForm& G,
+                 const Variable& alpha, int m)
 {
   CanonicalForm A= F;
@@ -561 +546 @@
     Variable alpha;
 #ifdef HAVE_FLINT
-    if ((!F.inCoeffDomain() && !G.inCoeffDomain()) && (hasFirstAlgVar (F, alpha) || hasFirstAlgVar (G, alpha)))
+    if ((!F.inCoeffDomain() && !G.inCoeffDomain()) &&
+        (hasFirstAlgVar (F, alpha) || hasFirstAlgVar (G, alpha)))
     {
       CanonicalForm result= mulFLINTQa (F, G, alpha);
@@ -624 +610 @@
       return modFLINTQ (F, G);
     else
+      //TODO newtonDivrem
      return mod (F, G);
 #else
@@ -683 +670 @@
       return divFLINTQ (F,G);
     else
+      //TODO newtonDivrem
       return div (F, G);
 #else
@@ -798 +786 @@
   nmod_poly_t buf;
 
+  int j, k, bufRepLength;
   for (CFIterator i= A; i.hasTerms(); i++)
   {
     convertFacCF2nmod_poly_t (buf, i.coeff());
 
-    int k= i.exp()*d;
-    int bufRepLength= (int) nmod_poly_length (buf);
-    for (int j= 0; j < bufRepLength; j++)
+    k= i.exp()*d;
+    bufRepLength= (int) nmod_poly_length (buf);
+    for (j= 0; j < bufRepLength; j++)
       nmod_poly_set_coeff_ui (result, j + k, nmod_poly_get_coeff_ui (buf, j));
     nmod_poly_clear (buf);
@@ -895 +884 @@
   zz_pX buf;
   zz_p *bufp;
+  int j, k, bufRepLength;
 
   for (CFIterator i= A; i.hasTerms(); i++)
@@ -903 +893 @@
       buf= convertFacCF2NTLzzpX (i.coeff());
 
-    int k= i.exp()*d;
+    k= i.exp()*d;
     bufp= buf.rep.elts();
-    int bufRepLength= (int) buf.rep.length();
-    for (int j= 0; j < bufRepLength; j++)
+    bufRepLength= (int) buf.rep.length();
+    for (j= 0; j < bufRepLength; j++)
       resultp [j + k]= bufp [j];
   }
@@ -927 +917 @@
   zz_pX buf2;
   zz_pX NTLMipo= convertFacCF2NTLzzpX (getMipo (alpha));
+  int j, k, buf1RepLength;
 
   for (CFIterator i= A; i.hasTerms(); i++)
@@ -938 +929 @@
       buf1= convertFacCF2NTLzz_pEX (i.coeff(), NTLMipo);
 
-    int k= i.exp()*d;
+    k= i.exp()*d;
     buf1p= buf1.rep.elts();
-    int buf1RepLength= (int) buf1.rep.length();
-    for (int j= 0; j < buf1RepLength; j++)
+    buf1RepLength= (int) buf1.rep.length();
+    for (j= 0; j < buf1RepLength; j++)
       resultp [j + k]= buf1p [j];
   }
@@ -966 +957 @@
   zz_pX buf2;
   zz_pX NTLMipo= convertFacCF2NTLzzpX (getMipo (alpha));
+  int j, k, kk, bufRepLength;
 
   for (CFIterator i= A; i.hasTerms(); i++)
@@ -977 +969 @@
       buf= convertFacCF2NTLzz_pEX (i.coeff(), NTLMipo);
 
-    int k= i.exp()*d;
-    int kk= (degAy - i.exp())*d;
+    k= i.exp()*d;
+    kk= (degAy - i.exp())*d;
     bufp= buf.rep.elts();
-    int bufRepLength= (int) buf.rep.length();
-    for (int j= 0; j < bufRepLength; j++)
+    bufRepLength= (int) buf.rep.length();
+    for (j= 0; j < bufRepLength; j++)
     {
       subA1p [j + k] += bufp [j];
@@ -1004 +996 @@
   zz_pX buf;
   zz_p *bufp;
+  int j, k, kk, bufRepLength;
 
   for (CFIterator i= A; i.hasTerms(); i++)
@@ -1009 +1002 @@
     buf= convertFacCF2NTLzzpX (i.coeff());
 
-    int k= i.exp()*d;
-    int kk= (degAy - i.exp())*d;
+    k= i.exp()*d;
+    kk= (degAy - i.exp())*d;
     bufp= buf.rep.elts();
-    int bufRepLength= (int) buf.rep.length();
-    for (int j= 0; j < bufRepLength; j++)
+    bufRepLength= (int) buf.rep.length();
+    for (j= 0; j < bufRepLength; j++)
     {
       subA1p [j + k] += bufp [j];
@@ -1053 +1046 @@
   int degfSubLf= degf;
   int deggSubLg= degg-lg;
-  int repLengthBuf2;
-  int repLengthBuf1;
+  int repLengthBuf2, repLengthBuf1, ind, tmp;
   zz_pE zzpEZero= zz_pE();
 
@@ -1068 +1060 @@
 
     buf1p= buf1.rep.elts();
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+    for (ind= 0; ind < repLengthBuf1; ind++)
       buf1p [ind]= fp [ind + lf];
     buf1.normalize();
@@ -1083 +1075 @@
     buf2.rep.SetLength ((long) repLengthBuf2);
     buf2p= buf2.rep.elts();
-    for (int ind= 0; ind < repLengthBuf2; ind++)
-    {
+    for (ind= 0; ind < repLengthBuf2; ind++)
       buf2p [ind]= gp [ind + lg];
-    }
     buf2.normalize();
 
@@ -1095 +1085 @@
     buf2p= buf2.rep.elts();
     buf1p= buf1.rep.elts();
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+    for (ind= 0; ind < repLengthBuf1; ind++)
       buf3p [ind]= buf1p [ind];
-    for (int ind= repLengthBuf1; ind < d; ind++)
+    for (ind= repLengthBuf1; ind < d; ind++)
       buf3p [ind]= zzpEZero;
-    for (int ind= 0; ind < repLengthBuf2; ind++)
+    for (ind= 0; ind < repLengthBuf2; ind++)
       buf3p [ind + d]= buf2p [ind];
     buf3.normalize();
@@ -1119 +1109 @@
       if (repLengthBuf2 > degfSubLf + 1)
         degfSubLf= repLengthBuf2 - 1;
-      int tmp= tmin (repLengthBuf1, deggSubLg + 1);
-      for (int ind= 0; ind < tmp; ind++)
+      tmp= tmin (repLengthBuf1, deggSubLg + 1);
+      for (ind= 0; ind < tmp; ind++)
         gp [ind + lg] -= buf1p [ind];
     }
@@ -1130 +1120 @@
     if (degfSubLf >= 0)
     {
-      for (int ind= 0; ind < repLengthBuf2; ind++)
+      for (ind= 0; ind < repLengthBuf2; ind++)
         fp [ind + lf] -= buf2p [ind];
     }
@@ -1168 +1158 @@
   int degfSubLf= degf;
   int deggSubLg= degg-lg;
-  int repLengthBuf2;
-  int repLengthBuf1;
+  int repLengthBuf2, repLengthBuf1, ind, tmp;
   zz_p zzpZero= zz_p();
   while (degf >= lf || lg >= 0)
@@ -1182 +1171 @@
 
     buf1p= buf1.rep.elts();
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+    for (ind= 0; ind < repLengthBuf1; ind++)
       buf1p [ind]= fp [ind + lf];
     buf1.normalize();
@@ -1197 +1186 @@
     buf2.rep.SetLength ((long) repLengthBuf2);
     buf2p= buf2.rep.elts();
-    for (int ind= 0; ind < repLengthBuf2; ind++)
+    for (ind= 0; ind < repLengthBuf2; ind++)
       buf2p [ind]= gp [ind + lg];
 
@@ -1209 +1198 @@
     buf2p= buf2.rep.elts();
     buf1p= buf1.rep.elts();
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+    for (ind= 0; ind < repLengthBuf1; ind++)
       buf3p [ind]= buf1p [ind];
-    for (int ind= repLengthBuf1; ind < d; ind++)
+    for (ind= repLengthBuf1; ind < d; ind++)
       buf3p [ind]= zzpZero;
-    for (int ind= 0; ind < repLengthBuf2; ind++)
+    for (ind= 0; ind < repLengthBuf2; ind++)
       buf3p [ind + d]= buf2p [ind];
     buf3.normalize();
@@ -1233 +1222 @@
       if (repLengthBuf2 > degfSubLf + 1)
         degfSubLf= repLengthBuf2 - 1;
-      int tmp= tmin (repLengthBuf1, deggSubLg + 1);
-      for (int ind= 0; ind < tmp; ind++)
+      tmp= tmin (repLengthBuf1, deggSubLg + 1);
+      for (ind= 0; ind < tmp; ind++)
         gp [ind + lg] -= buf1p [ind];
     }
@@ -1243 +1232 @@
     if (degfSubLf >= 0)
     {
-      for (int ind= 0; ind < repLengthBuf2; ind++)
+      for (ind= 0; ind < repLengthBuf2; ind++)
         fp [ind + lf] -= buf2p [ind];
     }
@@ -1265 +1254 @@
   int degf= deg(f);
   int k= 0;
-  int degfSubK;
-  int repLength;
+  int degfSubK, repLength, j;
   while (degf >= k)
   {
@@ -1277 +1265 @@
     buf.rep.SetLength ((long) repLength);
     bufp= buf.rep.elts();
-    for (int j= 0; j < repLength; j++)
+    for (j= 0; j < repLength; j++)
       bufp [j]= fp [j + k];
     buf.normalize();
@@ -1303 +1291 @@
   int degf= deg(f);
   int k= 0;
-  int degfSubK;
-  int repLength;
+  int degfSubK, repLength, j;
   while (degf >= k)
   {
@@ -1315 +1302 @@
     buf.rep.SetLength ((long) repLength);
     bufp= buf.rep.elts();
-    for (int j= 0; j < repLength; j++)
+    for (j= 0; j < repLength; j++)
       bufp [j]= fp [j + k];
     buf.normalize();
@@ -1472 +1459 @@
 #ifdef HAVE_FLINT
 void
-kronSubRecipro (nmod_poly_t subA1, nmod_poly_t subA2, const CanonicalForm& A, int d)
+kronSubRecipro (nmod_poly_t subA1, nmod_poly_t subA2, const CanonicalForm& A,
+                int d)
 {
   int degAy= degree (A);
@@ -1481 +1469 @@
   nmod_poly_t buf;
 
+  int k, kk, j, bufRepLength;
   for (CFIterator i= A; i.hasTerms(); i++)
   {
     convertFacCF2nmod_poly_t (buf, i.coeff());
 
-    int k= i.exp()*d;
-    int kk= (degAy - i.exp())*d;
-    int bufRepLength= (int) nmod_poly_length (buf);
-    for (int j= 0; j < bufRepLength; j++)
-    {
-      nmod_poly_set_coeff_ui (subA1, j + k, n_addmod (nmod_poly_get_coeff_ui (subA1, j+k), nmod_poly_get_coeff_ui (buf, j), getCharacteristic())); //TODO muß man subA1 coeffs von subA1 vorher auf null setzen??
-      nmod_poly_set_coeff_ui (subA2, j + kk, n_addmod (nmod_poly_get_coeff_ui (subA2, j + kk),nmod_poly_get_coeff_ui (buf, j), getCharacteristic()));
+    k= i.exp()*d;
+    kk= (degAy - i.exp())*d;
+    bufRepLength= (int) nmod_poly_length (buf);
+    for (j= 0; j < bufRepLength; j++)
+    {
+      nmod_poly_set_coeff_ui (subA1, j + k,
+                              n_addmod (nmod_poly_get_coeff_ui (subA1, j+k),
+                                        nmod_poly_get_coeff_ui (buf, j),
+                                        getCharacteristic()
+                                       )
+                             );
+      nmod_poly_set_coeff_ui (subA2, j + kk,
+                              n_addmod (nmod_poly_get_coeff_ui (subA2, j + kk),
+                                        nmod_poly_get_coeff_ui (buf, j),
+                                        getCharacteristic()
+                                       )
+                             );
     }
     nmod_poly_clear (buf);
@@ -1500 +1499 @@
 
 void
-kronSubRecipro (fmpz_poly_t subA1, fmpz_poly_t subA2, const CanonicalForm& A, int d)
+kronSubRecipro (fmpz_poly_t subA1, fmpz_poly_t subA2, const CanonicalForm& A,
+                int d)
 {
   int degAy= degree (A);
@@ -1509 +1509 @@
   fmpz_t coeff1, coeff2;
 
+  int k, kk, j, bufRepLength;
   for (CFIterator i= A; i.hasTerms(); i++)
   {
     convertFacCF2Fmpz_poly_t (buf, i.coeff());
 
-    int k= i.exp()*d;
-    int kk= (degAy - i.exp())*d;
-    int bufRepLength= (int) fmpz_poly_length (buf);
-    for (int j= 0; j < bufRepLength; j++)
-    {
-      fmpz_poly_get_coeff_fmpz (coeff1, subA1, j+k); //TODO muß man subA1 coeffs von subA1 vorher auf null setzen??
-                                                     // vielleicht ist es schneller fmpz_poly_get_ptr zu nehmen
+    k= i.exp()*d;
+    kk= (degAy - i.exp())*d;
+    bufRepLength= (int) fmpz_poly_length (buf);
+    for (j= 0; j < bufRepLength; j++)
+    {
+      fmpz_poly_get_coeff_fmpz (coeff1, subA1, j+k);
       fmpz_poly_get_coeff_fmpz (coeff2, buf, j);
       fmpz_add (coeff1, coeff1, coeff2);
@@ -1549 +1549 @@
   int degf= fmpz_poly_degree(f);
   int k= 0;
-  int degfSubK;
-  int repLength;
+  int degfSubK, repLength, j;
   fmpz_t coeff;
   while (degf >= k)
@@ -1562 +1561 @@
     fmpz_poly_init2 (buf, repLength);
     fmpz_init (coeff);
-    for (int j= 0; j < repLength; j++)
+    for (j= 0; j < repLength; j++)
     {
       fmpz_poly_get_coeff_fmpz (coeff, f, j + k);
@@ -1597 +1596 @@
 
   nmod_poly_t buf1,buf2, buf3;
-  /*nmod_poly_init_preinv (buf1, getCharacteristic(), ninv);
-  nmod_poly_init_preinv (buf2, getCharacteristic(), ninv);
-  nmod_poly_init_preinv (buf3, getCharacteristic(), ninv);*/
 
   if (nmod_poly_length (f) < (long) d*(k+1)) //zero padding
@@ -1610 +1606 @@
   int degfSubLf= degf;
   int deggSubLg= degg-lg;
-  int repLengthBuf2;
-  int repLengthBuf1;
-  //zz_p zzpZero= zz_p();
+  int repLengthBuf2, repLengthBuf1, ind, tmp;
   while (degf >= lf || lg >= 0)
   {
@@ -1621 +1615 @@
     else
       repLengthBuf1= degfSubLf + 1;
-    //cout << "repLengthBuf1= " << repLengthBuf1 << "\n";
-    //cout << "nmod_poly_length (buf1)= " << nmod_poly_length (buf1) << "\n";
     nmod_poly_init2_preinv (buf1, getCharacteristic(), ninv, repLengthBuf1);
-    //cout << "nmod_poly_length (buf1)= " << nmod_poly_length (buf1) << "\n";
-
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+
+    for (ind= 0; ind < repLengthBuf1; ind++)
       nmod_poly_set_coeff_ui (buf1, ind, nmod_poly_get_coeff_ui (f, ind+lf));
     _nmod_poly_normalise (buf1);
-    //cout << "nmod_poly_length (buf1)= " << nmod_poly_length (buf1) << "\n";
 
     repLengthBuf1= nmod_poly_length (buf1);
@@ -1640 +1630 @@
       repLengthBuf2= deggSubLg + 1;
 
-    //cout << "repLengthBuf2= " << repLengthBuf2 << "\n";
-    //cout << "nmod_poly_length (buf2)= " << nmod_poly_length (buf2) << "\n";
     nmod_poly_init2_preinv (buf2, getCharacteristic(), ninv, repLengthBuf2);
-    //cout << "nmod_poly_length (buf2)= " << nmod_poly_length (buf2) << "\n";
-    for (int ind= 0; ind < repLengthBuf2; ind++)
+    for (ind= 0; ind < repLengthBuf2; ind++)
       nmod_poly_set_coeff_ui (buf2, ind, nmod_poly_get_coeff_ui (g, ind + lg));
 
     _nmod_poly_normalise (buf2);
-    //cout << "nmod_poly_length (buf2)= " << nmod_poly_length (buf2) << "\n";
     repLengthBuf2= nmod_poly_length (buf2);
 
     nmod_poly_init2_preinv (buf3, getCharacteristic(), ninv, repLengthBuf2 + d);
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+    for (ind= 0; ind < repLengthBuf1; ind++)
       nmod_poly_set_coeff_ui (buf3, ind, nmod_poly_get_coeff_ui (buf1, ind));
-    for (int ind= repLengthBuf1; ind < d; ind++)
+    for (ind= repLengthBuf1; ind < d; ind++)
       nmod_poly_set_coeff_ui (buf3, ind, 0);
-    for (int ind= 0; ind < repLengthBuf2; ind++)
-      nmod_poly_set_coeff_ui (buf3, ind + d, nmod_poly_get_coeff_ui (buf2, ind));
+    for (ind= 0; ind < repLengthBuf2; ind++)
+      nmod_poly_set_coeff_ui (buf3, ind+d, nmod_poly_get_coeff_ui (buf2, ind));
     _nmod_poly_normalise (buf3);
 
@@ -1674 +1660 @@
       if (repLengthBuf2 > degfSubLf + 1)
         degfSubLf= repLengthBuf2 - 1;
-      int tmp= tmin (repLengthBuf1, deggSubLg + 1);
-      for (int ind= 0; ind < tmp; ind++)
-      //{
-        nmod_poly_set_coeff_ui (g, ind + lg, n_submod (nmod_poly_get_coeff_ui (g, ind + lg), nmod_poly_get_coeff_ui (buf1, ind), getCharacteristic()));
-        //cout << "nmod_poly_get_coeff_ui (g, ind + lg)= " << nmod_poly_get_coeff_ui (g, ind + lg) << "\n";
-      //}
+      tmp= tmin (repLengthBuf1, deggSubLg + 1);
+      for (ind= 0; ind < tmp; ind++)
+        nmod_poly_set_coeff_ui (g, ind + lg,
+                                n_submod (nmod_poly_get_coeff_ui (g, ind + lg),
+                                          nmod_poly_get_coeff_ui (buf1, ind),
+                                          getCharacteristic()
+                                         )
+                               );
     }
     if (lg < 0)
@@ -1690 +1678 @@
     if (degfSubLf >= 0)
     {
-      for (int ind= 0; ind < repLengthBuf2; ind++)
-        nmod_poly_set_coeff_ui (f, ind + lf, n_submod (nmod_poly_get_coeff_ui (f, ind + lf), nmod_poly_get_coeff_ui (buf2, ind), getCharacteristic()));
+      for (ind= 0; ind < repLengthBuf2; ind++)
+        nmod_poly_set_coeff_ui (f, ind + lf,
+                                n_submod (nmod_poly_get_coeff_ui (f, ind + lf),
+                                          nmod_poly_get_coeff_ui (buf2, ind),
+                                          getCharacteristic()
+                                         )
+                               );
     }
     nmod_poly_clear (buf1);
     nmod_poly_clear (buf2);
     nmod_poly_clear (buf3);
-    /*nmod_poly_init_preinv (buf1, getCharacteristic(), ninv);
-    nmod_poly_init_preinv (buf2, getCharacteristic(), ninv);
-    nmod_poly_init_preinv (buf3, getCharacteristic(), ninv);*/
-  }
-
-  /*nmod_poly_clear (buf1);
-  nmod_poly_clear (buf2);
-  nmod_poly_clear (buf3);*/
+  }
+
   nmod_poly_clear (f);
   nmod_poly_clear (g);
@@ -1726 +1713 @@
 
   fmpz_poly_t buf1,buf2, buf3;
-  /*nmod_poly_init_preinv (buf1, getCharacteristic(), ninv);
-  nmod_poly_init_preinv (buf2, getCharacteristic(), ninv);
-  nmod_poly_init_preinv (buf3, getCharacteristic(), ninv);*/
 
   if (fmpz_poly_length (f) < (long) d*(k+1)) //zero padding
@@ -1739 +1723 @@
   int degfSubLf= degf;
   int deggSubLg= degg-lg;
-  int repLengthBuf2;
-  int repLengthBuf1;
-  //zz_p zzpZero= zz_p();
+  int repLengthBuf2, repLengthBuf1, ind, tmp;
   fmpz_t tmp1, tmp2;
   while (degf >= lf || lg >= 0)
@@ -1751 +1733 @@
     else
       repLengthBuf1= degfSubLf + 1;
-    //cout << "repLengthBuf1= " << repLengthBuf1 << "\n";
-    //cout << "nmod_poly_length (buf1)= " << nmod_poly_length (buf1) << "\n";
+
     fmpz_poly_init2 (buf1, repLengthBuf1);
-    //cout << "nmod_poly_length (buf1)= " << nmod_poly_length (buf1) << "\n";
-
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+
+    for (ind= 0; ind < repLengthBuf1; ind++)
     {
       fmpz_poly_get_coeff_fmpz (tmp1, f, ind + lf);
@@ -1762 +1742 @@
     }
     _fmpz_poly_normalise (buf1);
-    //cout << "nmod_poly_length (buf1)= " << nmod_poly_length (buf1) << "\n";
 
     repLengthBuf1= fmpz_poly_length (buf1);
@@ -1773 +1752 @@
       repLengthBuf2= deggSubLg + 1;
 
-    //cout << "repLengthBuf2= " << repLengthBuf2 << "\n";
-    //cout << "nmod_poly_length (buf2)= " << nmod_poly_length (buf2) << "\n";
     fmpz_poly_init2 (buf2, repLengthBuf2);
-    //cout << "nmod_poly_length (buf2)= " << nmod_poly_length (buf2) << "\n";
-    for (int ind= 0; ind < repLengthBuf2; ind++)
+
+    for (ind= 0; ind < repLengthBuf2; ind++)
     {
       fmpz_poly_get_coeff_fmpz (tmp1, g, ind + lg);
@@ -1784 +1761 @@
 
     _fmpz_poly_normalise (buf2);
-    //cout << "nmod_poly_length (buf2)= " << nmod_poly_length (buf2) << "\n";
     repLengthBuf2= fmpz_poly_length (buf2);
 
     fmpz_poly_init2 (buf3, repLengthBuf2 + d);
-    for (int ind= 0; ind < repLengthBuf1; ind++)
+    for (ind= 0; ind < repLengthBuf1; ind++)
     {
       fmpz_poly_get_coeff_fmpz (tmp1, buf1, ind);  //oder fmpz_set (fmpz_poly_get_coeff_ptr (buf3, ind),fmpz_poly_get_coeff_ptr (buf1, ind))
       fmpz_poly_set_coeff_fmpz (buf3, ind, tmp1);
     }
-    for (int ind= repLengthBuf1; ind < d; ind++)
+    for (ind= repLengthBuf1; ind < d; ind++)
       fmpz_poly_set_coeff_ui (buf3, ind, 0);
-    for (int ind= 0; ind < repLengthBuf2; ind++)
+    for (ind= 0; ind < repLengthBuf2; ind++)
     {
       fmpz_poly_get_coeff_fmpz (tmp1, buf2, ind);
@@ -1816 +1792 @@
       if (repLengthBuf2 > degfSubLf + 1)
         degfSubLf= repLengthBuf2 - 1;
-      int tmp= tmin (repLengthBuf1, deggSubLg + 1);
-      for (int ind= 0; ind < tmp; ind++)
+      tmp= tmin (repLengthBuf1, deggSubLg + 1);
+      for (ind= 0; ind < tmp; ind++)
       {
         fmpz_poly_get_coeff_fmpz (tmp1, g, ind + lg);
@@ -1823 +1799 @@
         fmpz_sub (tmp1, tmp1, tmp2);
         fmpz_poly_set_coeff_fmpz (g, ind + lg, tmp1);
-        //cout << "nmod_poly_get_coeff_ui (g, ind + lg)= " << nmod_poly_get_coeff_ui (g, ind + lg) << "\n";
       }
     }
@@ -1835 +1810 @@
     if (degfSubLf >= 0)
     {
-      for (int ind= 0; ind < repLengthBuf2; ind++)
+      for (ind= 0; ind < repLengthBuf2; ind++)
       {
         fmpz_poly_get_coeff_fmpz (tmp1, f, ind + lf);
@@ -1846 +1821 @@
     fmpz_poly_clear (buf2);
     fmpz_poly_clear (buf3);
-    /*nmod_poly_init_preinv (buf1, getCharacteristic(), ninv);
-    nmod_poly_init_preinv (buf2, getCharacteristic(), ninv);
-    nmod_poly_init_preinv (buf3, getCharacteristic(), ninv);*/
-  }
-
-  /*nmod_poly_clear (buf1);
-  nmod_poly_clear (buf2);
-  nmod_poly_clear (buf3);*/
+  }
+
   fmpz_poly_clear (f);
   fmpz_poly_clear (g);
@@ -1873 +1842 @@
 
   nmod_poly_t buf;
-  //nmod_poly_init_preinv (buf, getCharacteristic(), ninv);
   CanonicalForm result= 0;
   int i= 0;
   int degf= nmod_poly_degree(f);
   int k= 0;
-  int degfSubK;
-  int repLength;
+  int degfSubK, repLength, j;
   while (degf >= k)
   {
@@ -1889 +1856 @@
 
     nmod_poly_init2_preinv (buf, getCharacteristic(), ninv, repLength);
-    for (int j= 0; j < repLength; j++)
+    for (j= 0; j < repLength; j++)
       nmod_poly_set_coeff_ui (buf, j, nmod_poly_get_coeff_ui (f, j + k));
-    //printf ("after set\n");
     _nmod_poly_normalise (buf);
-    //printf ("after normalise\n");
 
     result += convertnmod_poly_t2FacCF (buf, x)*power (y, i);
@@ -1899 +1864 @@
     k= d*i;
     nmod_poly_clear (buf);
-    //nmod_poly_init_preinv (buf, getCharacteristic(), ninv);
-  }
-  //printf ("after while\n");
-  //nmod_poly_clear (buf);
+  }
   nmod_poly_clear (f);
-  //printf ("after clear\n");
 
   return result;
@@ -1922 +1883 @@
   nmod_poly_init_preinv (F2, getCharacteristic(), ninv);
   kronSubRecipro (F1, F2, F, d1);
-  /*zz_pX TF1, TF2;
-  kronSubRecipro (TF1, TF2, F, d1);
-  Variable x= Variable (1);
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF1, x) == convertnmod_poly_t2FacCF (F1, x)) << "\n";
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF2, x) == convertnmod_poly_t2FacCF (F2, x)) << "\n";*/
 
   nmod_poly_t G1, G2;
@@ -1932 +1888 @@
   nmod_poly_init_preinv (G2, getCharacteristic(), ninv);
   kronSubRecipro (G1, G2, G, d1);
-  /*zz_pX TG1, TG2;
-  kronSubRecipro (TG1, TG2, G, d1);
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TG1, x) == convertnmod_poly_t2FacCF (G1, x)) << "\n";
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TG2, x) == convertnmod_poly_t2FacCF (G2, x)) << "\n";*/
-
 
   int k= d1*degree (M);
   nmod_poly_mullow (F1, F1, G1, (long) k);
-  /*MulTrunc (TF1, TF1, TG1, (long) k);
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF1, x) == convertnmod_poly_t2FacCF (F1, x)) << "\n";*/
 
   int degtailF= degree (tailcoeff (F), 1);;
@@ -1948 +1897 @@
   int taildegG= taildegree (G);
 
-  int b= nmod_poly_degree (F2) + nmod_poly_degree (G2) - k - degtailF - degtailG + d1*(2+taildegF + taildegG);
+  int b= nmod_poly_degree (F2) + nmod_poly_degree (G2) - k - degtailF - degtailG
+         + d1*(2+taildegF + taildegG);
   nmod_poly_mulhigh (F2, F2, G2, b);
   nmod_poly_shift_right (F2, F2, b);
-  /*mul (TF2, TF2, TG2);
-  if (deg (TF2) > k)
-  {
-    int b= deg (TF2) - k + 2;
-    TF2 >>= b;
-  }
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF2, x) == convertnmod_poly_t2FacCF (F2, x)) << "\n";*/
   int d2= tmax (nmod_poly_degree (F2)/d1, nmod_poly_degree (F1)/d1);
 
 
   CanonicalForm result= reverseSubst (F1, F2, d1, d2);
-  //CanonicalForm NTLres= reverseSubst (TF1, TF2, d1, d2);
-  //cout << "FINALtestkronSubReci= " << (NTLres == result) << "\n";
 
   nmod_poly_clear (F1);
@@ -2018 +1959 @@
   fmpz_poly_init (F2);
   kronSubRecipro (F1, F2, F, d1);
-  /*zz_pX TF1, TF2;
-  kronSubRecipro (TF1, TF2, F, d1);
-  Variable x= Variable (1);
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF1, x) == convertnmod_poly_t2FacCF (F1, x)) << "\n";
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF2, x) == convertnmod_poly_t2FacCF (F2, x)) << "\n";*/
 
   fmpz_poly_t G1, G2;
@@ -2028 +1964 @@
   fmpz_poly_init (G2);
   kronSubRecipro (G1, G2, G, d1);
-  /*zz_pX TG1, TG2;
-  kronSubRecipro (TG1, TG2, G, d1);
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TG1, x) == convertnmod_poly_t2FacCF (G1, x)) << "\n";
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TG2, x) == convertnmod_poly_t2FacCF (G2, x)) << "\n";*/
-
 
   int k= d1*degree (M);
   fmpz_poly_mullow (F1, F1, G1, (long) k);
-  /*MulTrunc (TF1, TF1, TG1, (long) k);
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF1, x) == convertnmod_poly_t2FacCF (F1, x)) << "\n";*/
 
   int degtailF= degree (tailcoeff (F), 1);;
@@ -2044 +1973 @@
   int taildegG= taildegree (G);
 
-  int b= fmpz_poly_degree (F2) + fmpz_poly_degree (G2) - k - degtailF - degtailG + d1*(2+taildegF + taildegG);
+  int b= fmpz_poly_degree (F2) + fmpz_poly_degree (G2) - k - degtailF - degtailG
+         + d1*(2+taildegF + taildegG);
   fmpz_poly_mulhigh_n (F2, F2, G2, b);
   fmpz_poly_shift_right (F2, F2, b);
-  /*mul (TF2, TF2, TG2);
-  if (deg (TF2) > k)
-  {
-    int b= deg (TF2) - k + 2;
-    TF2 >>= b;
-  }
-  cout << "testkronSubReci= " << (convertNTLzzpX2CF (TF2, x) == convertnmod_poly_t2FacCF (F2, x)) << "\n";*/
   int d2= tmax (fmpz_poly_degree (F2)/d1, fmpz_poly_degree (F1)/d1);
 
-
   CanonicalForm result= reverseSubst (F1, F2, d1, d2);
-
-  //CanonicalForm NTLres= reverseSubst (TF1, TF2, d1, d2);
-  //cout << "FINALtestkronSubReci= " << (NTLres == result) << "\n";
 
   fmpz_poly_clear (F1);
@@ -2077 +1996 @@
 
   int degAx= degree (A, 1);
-  //int degAy= degree (A, 2);
   int degBx= degree (B, 1);
-  //int degBy= degree (B, 2);
   int d1= degAx + 1 + degBx;
-  //int d2= tmax (degAy, degBy);
 
   CanonicalForm f= bCommonDen (F);