Changeset 93e7e91 in git

Timestamp:

Mar 25, 2010, 11:09:52 AM (13 years ago)

Author:

Hans Schönemann <hannes@…>

Branches:

(u'spielwiese', '0d6b7fcd9813a1ca1ed4220cfa2b104b97a0a003')

Children:

efa772b3587393300e3cca08fbc50cf501ba148a

Parents:

9f29bf99f5455597cc55d833ed57771d304ca795

Message:

memory leak in factorize

git-svn-id: file:///usr/local/Singular/svn/trunk@12671 2c84dea3-7e68-4137-9b89-c4e89433aadc

File:

• kernel/clapsing.cc (modified) (3 diffs)

kernel/clapsing.cc

@@ -723 +723 @@
 
 ideal singclap_factorize ( poly f, intvec ** v , int with_exps)
+/* destroys f, sets *v */
 {
   pTest(f);
@@ -773 +774 @@
       res->m[0]=pOne();
       // (**v)[0]=1; is already done
-      return res;
-    }
-    for(i=pVariables;i>0;i--)
-    {
-      e=pGetExp(f,i);
-      if(e!=0)
-      {
-        n--;
-        poly p=pOne();
-        pSetExp(p,i,1);
-        pSetm(p);
-        res->m[n]=p;
-        if (with_exps!=1) (**v)[n]=e;
-      }
-    }
+    }
+    else
+    {
+      for(i=pVariables;i>0;i--)
+      {
+        e=pGetExp(f,i);
+        if(e!=0)
+        {
+          n--;
+          poly p=pOne();
+          pSetExp(p,i,1);
+          pSetm(p);
+          res->m[n]=p;
+          if (with_exps!=1) (**v)[n]=e;
+        }
+      }
+    }
+    pDelete(&f);
     return res;
   }
@@ -1116 +1120 @@
     nDelete(&N);
   }
-  //if (f!=NULL) pDelete(&f);
+  if (f!=NULL) pDelete(&f);
   //PrintS("......S\n");
   return res;