Changeset 961c76 in git for libpolys

Timestamp:

Aug 19, 2016, 4:34:25 PM (8 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

a070b84d59be835a2946d1386edd3221d80f3fe7

Parents:

261ee2613fb64ea86222a19e5adc4673b9bc0175

Message:

chg: n_IsMOne for Z/2: maybe n_Zp, n_Zn, n_Z2m

Location:

libpolys/coeffs

Files:

• coeffs.h (modified) (1 diff)
• modulop.cc (modified) (1 diff)
• rmodulo2m.cc (modified) (1 diff)
• rmodulon.cc (modified) (1 diff)

libpolys/coeffs/coeffs.h

@@ -228 +228 @@
            (*cfIsZero)(number a, const coeffs r),
            (*cfIsOne)(number a, const coeffs r),
+       // IsMOne is used for printing os polynomials:
+       // -1 is only printed for constant monomials
            (*cfIsMOne)(number a, const coeffs r),
        //GreaterZero is used for printing of polynomials:

libpolys/coeffs/modulop.cc

@@ -188 +188 @@
   n_Test(a, r);
 
-  return ((r->npPminus1M == (long)a)&&(1L!=(long)a));
+  return ((r->npPminus1M == (long)a) &&(1L!=(long)a))/*for char 2*/;
 }
 

libpolys/coeffs/rmodulo2m.cc

@@ -388 +388 @@
 BOOLEAN nr2mIsMOne(number a, const coeffs r)
 {
-  return (r->mod2mMask  == (unsigned long)a);
+  return ((r->mod2mMask  == (unsigned long)a) &&(1L!=(long)a))/*for char 2^1*/;
 }
 

libpolys/coeffs/rmodulon.cc

@@ -512 +512 @@
   if (a == NULL) return FALSE;
 #endif
+  if(nrnIsOne(a,r)) return FALSE; // for char 2
   mpz_t t; mpz_init_set(t, (mpz_ptr)a);
   mpz_add_ui(t, t, 1);