Changeset 9952bd in git for libpolys/coeffs/Enumerator.h

Timestamp:

Sep 10, 2012, 2:13:09 PM (11 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'spielwiese', '0d6b7fcd9813a1ca1ed4220cfa2b104b97a0a003')

Children:

8d341e5425f8b7b26cdf77eec4ee78cbbb121c5c

Parents:

6dffa9e5b66ac5a81df2b68ff1c38dafc918b1f9

Message:

Changed enumerators to handle empty sets just like C# does

chg: enumerators handle empty sets just like C# does (together with Alexander Dreyer and Bjarke Roune)
fix: fixed comments for the above change
chg: adaptation of and minor changes to n[dl]Clear* implementations
add: introduced IBaseEnumerator::IsValid() = 0 (right now - for debug purpose only)

File:

• libpolys/coeffs/Enumerator.h (modified) (3 diffs)

libpolys/coeffs/Enumerator.h

@@ -22 +22 @@
 /** @class IBaseEnumerator
  * 
- * Base enumerator interface for simple iteration over a generic non-empty collection.
- *
- * Abstract API of enumerators for non-empty enumerable collections of standalone
- * objects. Inspired by IEnumerator from C#. Usage parrten can be as
- * follows:
+ * Base enumerator interface for simple iteration over a generic collection.
+ *
+ * Abstract API of enumerators for enumerable collections of standalone objects.
+ * Just like IEnumerator from C#. Usage pattern can be as follows:
  *
  * @code
- *   IBaseEnumerator itr = ...;
- *   itr.Reset(); // goes to the first element (must exist)
- *   do
+ *   IBaseEnumerator& itr = ...;
+ *   itr.Reset(); // goes to the "-1" element
+ *   // NOTE: itr is not useable here!
+ *   while( itr.MoveNext() )
  *   {
  *      do something custom with itr...
  *   }
- *   while( itr.MoveNext() )
  * @endcode
  *
- * Note that the first element must exist and available directly after Reset() call.
+ * Note that the Reset() 
  *
  * @sa IEnumerator
@@ -51 +50 @@
     virtual bool MoveNext() = 0;    
 
-    /// Sets the enumerator to its initial position, which is at the first element in the collection.
+    /// Sets the enumerator to its initial position: -1,
+    /// which is before the first element in the collection.
     virtual void Reset() = 0;
-//    virtual ~IEnumerator() {} // TODO: needed?
+
+    virtual ~IBaseEnumerator() {} // TODO: needed?
+
+  private:
+    IBaseEnumerator(const IBaseEnumerator&);
+    void operator=(const IBaseEnumerator&);
+
+  protected:
+    IBaseEnumerator(){}
+
+    /// Current position is inside the collection (not -1 or past the end)
+    virtual bool IsValid() const = 0;
 };
 
@@ -78 +89 @@
     /// Gets the current element in the collection (read only).
     virtual const_reference Current() const = 0;
+
+    virtual ~IAccessor() {} // TODO: needed?
+  
 };
 
 /** @class IEnumerator
  * 
- * Templated enumerator interface for simple iteration over a generic non-empty collection of T's.
- *
- * Abstract API of enumerators for non-empty enumerable collections of standalone
- * objects. Inspired by IEnumerator from C#. Usage parrten can be as
+ * Templated enumerator interface for simple iteration over a generic collection of T's.
+ *
+ * Abstract API of enumerators for generic enumerable collections of standalone
+ * objects of type T. Inspired by IEnumerator from C#. Usage parrten can be as
  * follows:
  *
  * @code
- *   IEnumerator<T> itr = ...;
- *   itr.Reset(); // goes to the first element (must exist)
- *   do
+ *   IEnumerator<T>& itr = ...;
+ *   
+ *   itr.Reset(); // goes before the first element, thus no itr.Current() is available here!
+ *   
+ *   while( itr.MoveNext() )
  *   {
  *      use/change itr.Current()...
  *   }
- *   while( itr.MoveNext() )
  * @endcode
  *