Changeset 9c8c05 in git for libpolys

Timestamp:

Jul 28, 2017, 12:03:43 PM (7 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '2a584933abf2a2d3082034c7586d38bb6de1a30a')

Children:

4639d07e5b8a374973b48216b40dba518c84a822526157566346cbba9a2808e99697dd1f042fe789

Parents:

8f8e18f68489ee23c13c87aa662b7eb3742a961f

Message:

juliacf.cc

File:

• libpolys/coeffs/juliacf.cc (modified) (9 diffs)

libpolys/coeffs/juliacf.cc

@@ -128 +128 @@
   jcf_number aa=(jcf_number)a;
   jcf_number bb=(jcf_number)b;
-  jl_function_t *func = jl_get_function(jl_base_module, "/");
+  jl_function_t *func = jl_get_function(jl_base_module, "divexact");
   return jcfNew(jl_call2(func, aa->val, bb->val),r);
 }
@@ -166 +166 @@
   jl_value_t *ii = jl_box_int64(1);
   jcf_number cc=(jcf_number)c;
-  jl_function_t *func = jl_get_function(jl_base_module, "/");
+  jl_function_t *func = jl_get_function(jl_base_module, "divexact");
   return jcfNew(jl_call2(func, ii, cc->val),r);
 }
@@ -182 +182 @@
 static BOOLEAN jcfGreater (number a,number b, const coeffs r)
 {
+  // if unsure, define it to "not equal"
   jcf_number aa=(jcf_number)a;
   jcf_number bb=(jcf_number)b;
@@ -205 +206 @@
   jl_function_t *func = jl_get_function(jl_base_module, "string");
   jl_value_t *res=jl_call1(func, aa->val);
-  // ???: produce the string representaion of a
+  // ???: produce the string representation of a
   //      and apply it to StringAppendS
   // char *s=jl_unbox_charptr(res);
@@ -212 +213 @@
 
 #if 0
+// optional:
 static void jcfPower (number a, int i, number * result, const coeffs r)
 {
@@ -219 +221 @@
 static const char * jcfRead (const char *s, number *a, const coeffs r)
 {
+  // read from s and returns the new position in s,
+  // if nothing is found, initialize a to 1 and return the original s
+  // example "2x3y3" -> a=2, s="x3y3"
+  // example "x" -> a=1, s="x"
+  // s is anything that Singular recognizes as monomial
   int i=1;
   s=eati(s,&i);
@@ -227 +234 @@
 static void jcfKillChar(coeffs r)
 {
+ // clean up everything from jcfInitChar
 }
 
@@ -237 +245 @@
 static BOOLEAN jcfCoeffIsEqual(const coeffs r, n_coeffType n, void * parameter)
 {
+  return TRUE;
 }
 
@@ -262 +271 @@
 static char* jcfCoeffName(const coeffs r)
 {
-  return (char*)"Float()";
+  return (char*)"juliacf";
 }
 
 BOOLEAN jcfInitChar(coeffs n, void* p)
 {
+  // p may be a pointer to an array known to julia
   n->is_field=TRUE;
   n->is_domain=TRUE;
-  n->rep=n_rep_float;
 
   n->cfKillChar = jcfKillChar;
-  n->ch = 0;
+  n->ch = 0; //???
   n->cfCoeffString = jcfCoeffString;
   n->cfCoeffName = jcfCoeffName;