Changeset 9fc2688 in git for libpolys/coeffs/rmodulo2m.cc

Timestamp:

Oct 13, 2011, 10:04:22 PM (13 years ago)

Author:

Niels Ranosch <ranosch@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

7cc086cb5be2cac29039c89051bc9f20438a08eb

Parents:

d2f72035f91977026085471ad553a309006a6f66

git-author:

Niels Ranosch <ranosch@mfo.de>2011-10-13 22:04:22+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 16:14:07+01:00

Message:

CHG: Note that NATNUMBER stands for 'unsigned long' now, and thus its instances can not be negative!

File:

• libpolys/coeffs/rmodulo2m.cc (modified) (1 diff)

libpolys/coeffs/rmodulo2m.cc

@@ -470 +470 @@
     power of 2 (<= 2^m) that is contained in b.
   */
-  assume((NATNUMBER)b != 0);
+  assume((NATNUMBER) b != 0);
   NATNUMBER g = 1;
-  NATNUMBER b_div = (NATNUMBER)b;
+  NATNUMBER b_div = (NATNUMBER) b;
+  
+  /*
+   * b_div is unsigned, so that (b_div < 0) evaluates false at compile-time
+   *
   if (b_div < 0) b_div = -b_div; // b_div now represents |b|, BUT b_div is unsigned!
+  */
+
   NATNUMBER rr = 0;
   while ((g < r->mod2mMask ) && (b_div > 0) && (b_div % 2 == 0))