Changeset a14509a in git

Timestamp:

Dec 12, 2007, 4:02:46 PM (16 years ago)

Author:

Simon King <king@…>

Branches:

(u'spielwiese', '4a9821a93ffdc22a6696668bd4f6b8c9de3e6c5f')

Children:

4735076c7c6e1d5c452b31791ace88f2aa0001cd

Parents:

04923be9902d7ec2a4bea53a0369a5b8dce73d95

Message:

Fixing severe bug in invariant_basis (finvar.lib)


git-svn-id: file:///usr/local/Singular/svn/trunk@10459 2c84dea3-7e68-4137-9b89-c4e89433aadc

File:

• Singular/LIB/finvar.lib (modified) (8 diffs)

Singular/LIB/finvar.lib

@@ -1 +1 @@
 ///////////////////////////////////////////////////////////////////////////////
-version="$Id: finvar.lib,v 1.69 2007-06-25 18:14:48 king Exp $"
+version="$Id: finvar.lib,v 1.70 2007-12-12 15:02:46 king Exp $"
 category="Invariant theory";
 info="
@@ -1591 +1591 @@
   }
   def br=basering;
+  ideal vars = maxideal(1);
   ideal mon=sort(maxideal(g))[1];      // needed for constructing a general
   int m=ncols(mon);                    // homogeneous polynomial of degree g
@@ -1617 +1618 @@
   execute("ring T=("+charstr(br)+"),("+varstr(br)+",p(1..m)),lp;");
   // p(1..m) are the general coefficients of the general polynomial of degree g
-  execute("ideal vars="+varstr(br)+";");
+  ideal vars = fetch(br,vars);
   map f;
   ideal mon=imap(br,mon);
@@ -6951 +6952 @@
 ASSUME:  n is the number of variables of the basering
 RETURN:  secondary invariants of the invariant ring (type <matrix>)
-DISPLAY: information if v does not equal 0
+DISPLAY: information on the progress of computation if v does not equal 0
 THEORY:  Secondary invariants are generated following \"Generating Invariant
          Rings of Finite Groups over Arbitrary Fields\" by Kemper (1996).
@@ -7010 +7011 @@
   }
   ring alskdfalkdsj=0,x,dp;
-  matrix M[1][2]=1,(1-x)^n;            // we look at our primary invariants as
+  matrix M[1][2]=1,(1-x)^n;            
   export alskdfalkdsj;
-  export M;
+  export M;                            // we look at our primary invariants as
   setring br;                          // such of the subgroup that only
   matrix REY=matrix(maxideal(1));      // contains the identity, this means that
@@ -7029 +7030 @@
     "";
   }
-  matrix trivialS, trivialSI=secondary_charp(P,REY,"alskdfalkdsj",v);
-  kill trivialSI;
+  matrix trivialS, trivialIS=secondary_charp(P,REY,"alskdfalkdsj",v);
+  kill trivialIS;
   kill alskdfalkdsj;
   // now we have those secondary invariants
@@ -7066 +7067 @@
   execute("ring R=("+charstr(br)+"),(x(1..n),y(1..n),h),dp;");
   execute("minpoly=number("+mp+");");
-  map f=br,maxideal(1);                // canonical mapping
+  // map f=br,maxideal(1);                // canonical mapping
   matrix M[k][m+k*n];
-  M[1..k,1..m]=matrix(f(M(2)));        // will contain a module -
-  matrix P=f(P);                       // primary invariants in the new ring
+  M[1..k,1..m]=matrix(fetch(br,M(2)));        // will contain a module -
+  matrix P=fetch(br,P);                       // primary invariants in the new ring
   for (i=1;i<=n;i++)
   { for (j=1;j<=k;j++)
@@ -7082 +7083 @@
   ideal substitute=maxideal(1),ideal(P),1;
   f=R,substitute;                      // replacing y(1..n) by primary
-                                       // invariants -
+                                       // invariants and h by 1 -
   M(2)=f(M);                           // M(2) is the new module
   m=ncols(M(2));