Changeset a241bd in git

Timestamp:

Jun 21, 2020, 3:19:29 PM (3 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '8d54773d6c9e2f1d2593a28bc68b7eeab54ed529')

Children:

28160bf3da8b285f95c9c99722a2c405c62d7af2

Parents:

b8c4c79e672b9f92ac6010f6a968f8c437e1eccc

Message:

polynomail division via syz for nc-rings

Files:

• kernel/polys.cc (modified) (6 diffs)
• libpolys/polys/monomials/p_polys.cc (modified) (1 diff)

kernel/polys.cc

@@ -52 +52 @@
   }
 #endif
-  if (pNext(q)!=NULL)
+  if ((pNext(q)!=NULL)||rIsNCRing(r))
   { /* This means that q != 0 consists of at least two terms*/
-    if (rIsLPRing(r))
-    {
-      WerrorS("not implemented for letterplace rings");
-      return NULL;
-    }
     if(p_GetComp(p,r)==0)
     {
       if((rFieldType(r)==n_transExt)
       &&(convSingTrP(p,r))
-      &&(convSingTrP(q,r)))
+      &&(convSingTrP(q,r))
+      &&(!rIsNCRing(r)))
       {
         poly res=singclap_pdivide(p, q, r);
@@ -71 +67 @@
       }
       else if ((r->cf->convSingNFactoryN!=ndConvSingNFactoryN)
-      &&(!rField_is_Ring(r)))
+      &&(!rField_is_Ring(r))
+      &&(!rIsNCRing(r)))
       {
         poly res=singclap_pdivide(p, q, r);
@@ -127 +124 @@
           if((rFieldType(r)==n_transExt)
           &&(convSingTrP(I->m[i],r))
-          &&(convSingTrP(q,r)))
+          &&(convSingTrP(q,r))
+          &&(!rIsNCRing(r)))
           {
             h=singclap_pdivide(I->m[i],q,r);
           }
           else if ((r->cf->convSingNFactoryN!=ndConvSingNFactoryN)
-          &&(!rField_is_Ring(r)))
+          &&(!rField_is_Ring(r))
+          &&(!rIsNCRing(r)))
             h=singclap_pdivide(I->m[i],q,r);
           else
@@ -188 +187 @@
     return NULL;
   }
-  if (pNext(q)!=NULL)
+  if ((pNext(q)!=NULL)||rIsNCRing(r))
   { /* This means that q != 0 consists of at least two terms*/
-    if (rIsLPRing(r))
-    {
-      WerrorS("not implemented for letterplace rings");
-      return NULL;
-    }
     if(p_GetComp(p,r)==0)
     {
       if((rFieldType(r)==n_transExt)
       &&(convSingTrP(p,r))
-      &&(convSingTrP(q,r)))
+      &&(convSingTrP(q,r))
+      &&(!rIsNCRing(r)))
       {
         poly res=singclap_pdivide(p, q, r);
@@ -205 +200 @@
       }
       else if ((r->cf->convSingNFactoryN!=ndConvSingNFactoryN)
-      &&(!rField_is_Ring(r)))
+      &&(!rField_is_Ring(r))
+      &&(!rIsNCRing(r)))
       {
         poly res=singclap_pdivide(p, q, r);
@@ -261 +257 @@
           if((rFieldType(r)==n_transExt)
           &&(convSingTrP(I->m[i],r))
-          &&(convSingTrP(q,r)))
+          &&(convSingTrP(q,r))
+          &&(!rIsNCRing(r)))
           {
             h=singclap_pdivide(I->m[i],q,r);
           }
           else if ((r->cf->convSingNFactoryN!=ndConvSingNFactoryN)
-          &&(!rField_is_Ring(r)))
+          &&(!rField_is_Ring(r))
+          &&(!rIsNCRing(r)))
             h=singclap_pdivide(I->m[i],q,r);
           else

libpolys/polys/monomials/p_polys.cc

@@ -1569 +1569 @@
   if(!p_IsConstant(b,r))
   {
-    if (rIsLPRing(r))
-    {
-      WerrorS("not implemented for letterplace rings");
+    if (rIsNCRing(r))
+    {
+      WerrorS("p_DivideM not implemented for non-commuative rings");
       return NULL;
     }