Changeset a2e447 in git

Timestamp:

Dec 16, 2014, 2:22:02 PM (9 years ago)

Author:

Hans Schoenemann <hannes@…>

Branches:

(u'spielwiese', '8e0ad00ce244dfd0756200662572aef8402f13d5')

Children:

75f460d8b1424a14103e3ee48d499b71e1cb46ee

Parents:

2fe92a21aa722bbb031cbd6accd0689cee649df8

Message:

remark: CopyD on list elements

File:

• Singular/ipshell.cc (modified) (3 diffs)

Singular/ipshell.cc

@@ -2091 +2091 @@
     if ((LL->nr >= 0) && LL->m[0].rtyp == BIGINT_CMD)
     {
-      number tmp= (number) LL->m[0].data; // .CopyD()? see below
-      n_MPZ (modBase, tmp, coeffs_BIGINT); // FIXME: deletes tmp: previous CopyD() should NOT be necessary! 
+      number tmp= (number) LL->m[0].data; // never use CopyD() on list elements
+                                    // assume that tmp is integer, not rational
+      n_MPZ (modBase, tmp, coeffs_BIGINT);
     }
     else if (LL->nr >= 0 && LL->m[0].rtyp == INT_CMD)
@@ -5267 +5268 @@
   else if ((pn->name != NULL) && (strcmp(pn->name, "integer") == 0))
   {
-    // TODO: change to use coeffs_BIGINT!? 
+    // TODO: change to use coeffs_BIGINT!?
     modBase = (mpz_ptr) omAlloc(sizeof(mpz_t));
     mpz_init_set_si(modBase, 0);
@@ -5317 +5318 @@
         //ringtype = 1;       // Use Z/2^ch
         cf=nInitChar(n_Z2m,(void*)(long)modExponent);
+        mpz_clear(modBase);
         omFreeSize (modBase, sizeof (mpz_t));
       }