Changeset a5fb9a in git

Timestamp:

Dec 21, 2014, 1:15:48 AM (9 years ago)

Author:

Jakob Kroeker <kroeker@…>

Branches:

(u'spielwiese', 'd0474371d8c5d8068ab70bfb42719c97936b18a6')

Children:

f533f6f7667328bccb271b19b2f603aaebe41596

Parents:

20863c905e3e6d10e3e1e6de5a625a88d4ba28b2

git-author:

Jakob Kroeker <kroeker@math.uni-hannover.de>2014-12-21 01:15:48+01:00

git-committer:

Jakob Kroeker <kroeker@math.uni-hannover.de>2014-12-21 01:17:46+01:00

Message:

fixed lusolve (track issue 358)

Files:

• Tst/Short.lst (modified) (1 diff)
• Tst/Short/bug_358.res.gz.uu (added)
• Tst/Short/bug_358.stat (added)
• Tst/Short/bug_358.tst (added)
• kernel/linear_algebra/linearAlgebra.cc (modified) (4 diffs)

Tst/Short.lst

@@ -36 +36 @@
 Short/bug_34.tst
 Short/bug_35.tst
+Short/bug_358.tst
 Short/bug_36.tst
 Short/bug_37.tst

kernel/linear_algebra/linearAlgebra.cc

@@ -407 +407 @@
   /* determine whether uMat * xVec = yVec is solvable */
   bool isSolvable = true;
-  bool isZeroRow; int nonZeroRowIndex;
+  bool isZeroRow;
+  int nonZeroRowIndex = 0 ;   // handle case that the matrix is zero
   for (int r = m; r >= 1; r--)
   {
@@ -430 +431 @@
        solution space will be. Thus, we start with the possibly too wide
        matrix N and later copy the relevant columns of N into H. */
-    int nonZeroC; int lastNonZeroC = n + 1;
+    int nonZeroC  =  0 ; 
+    int lastNonZeroC = n + 1;
+
     for (int r = nonZeroRowIndex; r >= 1; r--)
     {
       for (nonZeroC = 1; nonZeroC <= n; nonZeroC++)
         if (MATELEM(uMat, r, nonZeroC) != NULL) break;
+
       for (int w = lastNonZeroC - 1; w >= nonZeroC + 1; w--)
       {
@@ -467 +471 @@
       lastNonZeroC = nonZeroC;
     }
+    for (int w = lastNonZeroC - 1; w >= 1; w--)
+    {
+       // remaining variables are free
+       dim++;
+       MATELEM(N, w, dim) = pOne();
+    }
+
     if (dim == 0)
     {
@@ -484 +495 @@
     idDelete((ideal*)&N);
   }
-
   idDelete((ideal*)&cVec);
   idDelete((ideal*)&yVec);