Changeset a8ee9f in git

Timestamp:

Aug 10, 2011, 7:47:18 PM (12 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'jengelh-datetime', 'ceac47cbc86fe4a15902392bdbb9bd2ae0ea02c6')(u'spielwiese', 'a800fe4b3e9d37a38c5a10cc0ae9dfa0c15a4ee6')

Children:

5ad2f83d3e2adb737f473c82dc9e1098500624e9

Parents:

5ff1d31f3d80f972b5abf4d4435d01cb9b033ffb

git-author:

Oleksandr Motsak <motsak@mathematik.uni-kl.de>2011-08-10 19:47:18+02:00

git-committer:

Mohamed Barakat <mohamed.barakat@rwth-aachen.de>2011-11-09 13:19:14+01:00

Message:

FIX: use new MPZ<->NUMBER conversions for coeffs + coeffs_BIGINT

Location:

Singular

Files:

• misc_ip.cc (modified) (8 diffs)
• misc_ip.h (modified) (2 diffs)

Singular/misc_ip.cc

@@ -6 +6 @@
  * This file provides miscellaneous functionality.
  *
- * For more general information, see the documentation in
- * misc_ip.h.
- *
- * @author Frank Seelisch
+ * For more general information, see the documentation in misc_ip.h.
  *
  * @internal @version \$Id$
@@ -18 +15 @@
 // include header files
 #include <kernel/mod2.h>
-#include <Singular/lists.h>
-#include <kernel/longrat.h>
-#include <Singular/misc_ip.h>
-#include <Singular/feOpt.h>
-#include <Singular/silink.h>
+#include <misc/auxiliary.h>
+
+#include "misc_ip.h"
+#include "ipid.h"
+
+#include <coeffs/coeffs.h>
+// #include <coeffs/longrat.h>
+
+#include "feOpt.h"
+#include "silink.h"
 
 void number2mpz(number n, mpz_t m)
 {
-  if (SR_HDL(n) & SR_INT) mpz_init_set_si(m, SR_TO_INT(n));     /* n fits in an int */
-  else             mpz_init_set(m, (mpz_ptr)n->z);
+  n_MPZ(m, n, coeffs_BIGINT);
 }
 
 number mpz2number(mpz_t m)
 {
-  number z = ALLOC_RNUMBER();
-  mpz_init_set(z->z, m);
-  mpz_init_set_ui(z->n, 1);
-  z->s = 3;
-  return z;
-}
+  return n_Init(m, coeffs_BIGINT);
+}
+
 
 void divTimes(mpz_t n, mpz_t d, int* times)
@@ -111 +109 @@
   else
   {
-    number nn = nlRInit(ui);
-    mpz_set_ui(nn->z,ui);
+    number nn = n_Init(ui, coeffs_BIGINT);
     L->m[index].rtyp = BIGINT_CMD; L->m[index].data = (void*)nn;
   }
@@ -176 +173 @@
 */
 
+
+
 /* n and pBound are assumed to be bigint numbers */
 lists primeFactorisation(const number n, const number pBound)
@@ -188 +187 @@
   int positive=1; int probTest = 0;
 
-  if (!nlIsZero(n))
-  {
-    if (!nlGreaterZero(n))
+  if (!n_IsZero(n, coeffs_BIGINT))
+  {
+    if (!n_GreaterZero(n, coeffs_BIGINT))
     {
       positive=-1;
@@ -332 +331 @@
 }
 
-#include <string.h>
-#include <unistd.h>
-#include <stdio.h>
-#include <stddef.h>
-#include <stdlib.h>
-#include <time.h>
-
+#include <omalloc/omalloc.h>
 #include <omalloc/mylimits.h>
-#include <omalloc/omalloc.h>
+
 #include <misc/options.h>
-#include <kernel/febase.h>
-#include <Singular/cntrlc.h>
-#include <kernel/page.h>
-#include <Singular/ipid.h>
-#include <Singular/ipshell.h>
-#include <kernel/kstd1.h>
-#include <Singular/subexpr.h>
-#include <kernel/timer.h>
 #include <misc/intvec.h>
+
 #include <polys/monomials/ring.h>
 #include <polys/templates/p_Procs.h>
-/* Needed for debug Version of p_SetRingOfLeftv, Oliver */
-#ifdef PDEBUG
-#include <polys/polys.h>
-#endif
-#include <Singular/version.h>
-
-#include <Singular/static.h>
+
+#include <kernel/febase.h>
+#include <kernel/page.h>
+#include <kernel/kstd1.h>
+#include <kernel/timer.h>
+
+
+#include "subexpr.h"
+#include "cntrlc.h"
+#include "ipid.h"
+#include "ipshell.h"
+
+#include "version.h"
+#include "static.h"
+
 #ifdef HAVE_STATIC
 #undef HAVE_DYN_RL
@@ -372 +366 @@
 #ifdef HAVE_FACTORY
 #define SI_DONT_HAVE_GLOBAL_VARS
-#include <factory/factory.h>
+//#include <factory/factory.h>
 // libfac:
   extern const char * libfac_version;
@@ -399 +393 @@
 *}
 */
+
+#include <string.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <stddef.h>
+#include <stdlib.h>
+#include <time.h>
+
 
 void singular_example(char *str)

Singular/misc_ip.h

@@ -15 +15 @@
  *           these algorithms have been moved to the C/C++ kernel.
  *
- * @author Frank Seelisch
+ * @author Frank Seelisch, Oleksandr Motsak
  *
  * @internal @version \$Id$
@@ -25 +25 @@
 #define MISC_H
 
+#include <misc/auxiliary.h>
+#include <coeffs/coeffs.h>
+
+#include <kernel/structs.h>
 #include <coeffs/si_gmp.h>
-#include <kernel/structs.h>
 
-// include basic SINGULAR structures
-/* So far nothing is required. */
-
-/**
- * Converts a non-negative bigint number into a GMP number.
- *
- **/
-void number2mpz(number n,   /**< [in]  a bigint number >= 0  */
-                mpz_t m     /**< [out] the GMP equivalent    */
-               );
-               
-/**
- * Converts a non-negative GMP number into a bigint number.
- *
- * @return the bigint number representing the given GMP number
- **/
-number mpz2number(mpz_t m   /**< [in]  a GMP number >= 0  */
-                 );
+#include <Singular/lists.h>
 
 /**