Changeset b4ecd2 in git

Timestamp:

Jan 21, 2013, 8:20:40 PM (11 years ago)

Author:

Oleksandr Motsak <motsak@…>

Branches:

(u'fieker-DuVal', '117eb8c30fc9e991c4decca4832b1d19036c4c65')(u'spielwiese', 'd08f5f0bb3329b8ca19f23b74cb1473686415c3a')

Children:

74c52ced49c3c72d9aca4a3cc22f921a3f949687

Parents:

1f1fb0ae2d0228deb0e78489ca037165df05672b

Message:

fix: NULL deref in qideal test

NOTE: adaptation of 071e6adf671c14d7003accadcce5271a90cde970 to SW

File:

• libpolys/polys/simpleideals.cc (modified) (1 diff)

libpolys/polys/simpleideals.cc

@@ -77 +77 @@
 #endif
 
-/* index of generator with leading term in ground ring (if any);
-   otherwise -1 */
+/// index of generator with leading term in ground ring (if any); 
+/// otherwise -1
 int id_PosConstant(ideal id, const ring r)
 {
-  int k;
-  for (k = IDELEMS(id)-1; k>=0; k--)
-  {
-    if (p_LmIsConstantComp(id->m[k], r) == TRUE)
-      return k;
-  }
+  id_Test(id, r);
+  const int N = IDELEMS(id) - 1; 
+  const poly * m = id->m + N; 
+ 
+  for (int k = N; k >= 0; --k, --m)
+  {
+    const poly p = *m;
+    if (p!=NULL)
+       if (p_LmIsConstantComp(p, r) == TRUE)
+         return k;
+  }
+   
   return -1;
 }