Changeset b533b3 in git for kernel/ideals.cc

Timestamp:

Jan 18, 2007, 2:22:14 PM (17 years ago)

Author:

Hans Schönemann <hannes@…>

Branches:

(u'spielwiese', 'fe61d9c35bf7c61f2b6cbf1b56e25e2f08d536cc')

Children:

27afa17ad199291fbbc49248d936b0af2732e9da

Parents:

35ee46ccc87abc5a90d3893f8d9348ede15b26f1

Message:

*hannes: simplify


git-svn-id: file:///usr/local/Singular/svn/trunk@9737 2c84dea3-7e68-4137-9b89-c4e89433aadc

File:

• kernel/ideals.cc (modified) (5 diffs)

kernel/ideals.cc

@@ -2 +2 @@
 *  Computer Algebra System SINGULAR     *
 ****************************************/
-/* $Id: ideals.cc,v 1.34 2007-01-12 12:41:46 Singular Exp $ */
+/* $Id: ideals.cc,v 1.35 2007-01-18 13:22:14 Singular Exp $ */
 /*
 * ABSTRACT - all basic methods to manipulate ideals
@@ -182 +182 @@
 void idNorm(ideal id)
 {
-  for (int i=0; i<IDELEMS(id); i++)
+  for (int i=IDELEMS(id)-1; i>-0; i--)
   {
     if (id->m[i] != NULL)
@@ -203 +203 @@
     if (id->m[i]!=NULL)
     {
-      for (j=k-1; j>=0; j--)
-      {
-        if ((i!=j)
-        && (id->m[j]!=NULL)
-        && (pComparePolys(id->m[i], id->m[j])))
+      for (j=k-1; j>i; j--)
+      {
+        if (id->m[j]!=NULL)
+        {
+          if(pComparePolys(id->m[i], id->m[j]))
+          {
+            pDelete(&id->m[j]);
+          }
+        }
+      }
+    }
+  }
+}
+
+/*2
+* ideal id = (id[i])
+* if id[i] = id[j] then id[j] is deleted for j > i
+*/
+void idDelEquals(ideal id)
+{
+  int i, j, t;
+  int k = IDELEMS(id), l = k;
+  for (i=k-1; i>=0; i--)
+  {
+    if (id->m[i]!=NULL)
+    {
+      for (j=k-1; j>i; j--)
+      {
+        if ((id->m[j]!=NULL)
+        && (pEqualPolys(id->m[i], id->m[j])))
         {
           pDelete(&id->m[j]);
         }
-      }
-    }
-  }
-}
-
-/*2
-* ideal id = (id[i])
-* if id[i] = id[j] then id[j] is deleted for j > i
-*/
-void idDelEquals(ideal id)
-{
-  int i, j, t;
-  int k = IDELEMS(id), l = k;
-  for (i=k-1; i>=0; i--)
-  {
-    for (j=k-1; j>i; j--)
-    {
-      if ((i!=j)
-      && (id->m[i]!=NULL) && (id->m[j]!=NULL)
-      && (pEqualPolys(id->m[i], id->m[j])))
-      {
-        pDelete(&id->m[j]);
       }
     }
@@ -244 +247 @@
 {
   int i, j, t;
-  int k = IDELEMS(id), l = k;
+  int k = IDELEMS(id);
   for (i=k-1; i>=0; i--)
   {
     if (id->m[i] != NULL)
     {
-      for (j=l-1; j>=0; j--)
-      {
-        if ((i!=j)
-        && (id->m[j] != NULL)
+      for (j=k-1; j>i; j--)
+      {
+        if ((id->m[j] != NULL)
         && pLmEqual(id->m[i], id->m[j]))
         {
@@ -270 +272 @@
     if (id->m[i] != NULL)
     {
-      for (j=k-1; j>=0; j--)
-      {
-        if ((i!=j)
-        && (id->m[j]!=NULL)
-        && pDivisibleBy(id->m[i], id->m[j]))
+      for (j=k-1; j>i; j--)
+      {
+        if (id->m[j]!=NULL)
         {
-          pDelete(&id->m[j]);
+          if(pDivisibleBy(id->m[i], id->m[j]))
+          {
+            pDelete(&id->m[j]);
+          }
+          else if(pDivisibleBy(id->m[j], id->m[i]))
+          {
+            pDelete(&id->m[i]);
+          }
         }
       }